-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure hyperlinks de-underline when pointer leaves terminal #9195
Merged
DHowett
merged 1 commit into
microsoft:main
from
Don-Vito:9141-deunderline-link-pointer-exit
Feb 17, 2021
Merged
Ensure hyperlinks de-underline when pointer leaves terminal #9195
DHowett
merged 1 commit into
microsoft:main
from
Don-Vito:9141-deunderline-link-pointer-exit
Feb 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-TerminalControl
Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)
Impact-Visual
It look bad.
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Product-Terminal
The new Windows Terminal.
labels
Feb 17, 2021
carlos-zamora
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
DHowett
added
the
zPreview-Service-Queued-1.13
A floating label that tracks the current Preview version for servicing purposes.
label
Feb 17, 2021
DHowett
approved these changes
Feb 17, 2021
DHowett
changed the title
Ensure hyperlinks de-underlined when pointer leaves terminal
Ensure hyperlinks de-underline when pointer leaves terminal
Feb 17, 2021
Thank you! |
1 similar comment
Thank you! |
DHowett
added
zStable-Service-Queued-1.12
A floating label that tracks the current Stable version for servicing purposes.
and removed
zPreview-Service-Queued-1.13
A floating label that tracks the current Preview version for servicing purposes.
zStable-Service-Queued-1.12
A floating label that tracks the current Stable version for servicing purposes.
labels
Feb 23, 2021
DHowett
pushed a commit
that referenced
this pull request
Feb 23, 2021
🎉 Handy links: |
ghost
mentioned this pull request
Mar 1, 2021
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-TerminalControl
Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)
Impact-Visual
It look bad.
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Product-Terminal
The new Windows Terminal.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced PointerExited handler to nullify last hovered cell
(which will also de-underline the hyperlink if required).
Closes #9141