-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the shell extension's dependency on fmt for huge savings #9552
Conversation
Yeah, this one-line change shaves off almost half the binary. Binary size savings (x64 Release): Note | WindowsTerminalShellExt.dll ------ | --------------------------- Before | 130048 After | 73728 Delta | 56320 %Delta | 43.3%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we completely cut fmt from ShellExtension then?
Bruh, how do you find this stuff haha. Good work!
This does complete pull fmt from ShellExt Found the waste using @Austin-Lamb’s tools 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you meant was "Lose up to 43 percent of your size with this one weird trick!"
ha! |
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Yeah, this one-line change shaves off almost half the binary. Binary size savings (x64 Release): Note | WindowsTerminalShellExt.dll ------ | --------------------------- Before | 130048 After | 73728 Delta | -56320 %Delta | -43.3% (cherry picked from commit 9069fca)
🎉 Handy links: |
🎉 Handy links: |
Yeah, this one-line change shaves off almost half the binary.
Binary size savings (x64 Release):