-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent arrow keys from dismissing tab renamer #9633
Conversation
@KalleOlaviNiemitalo - FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly blocking over the question about whether it breaks other things.
_receivedKeyDown = true; | ||
|
||
// GH#9632 - mark navigation buttons as handled. | ||
// This should prevent the tab view to use this key for navigation between tabs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this break ctrl-left (move back word), shift-left (select leftward), etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this will not break it. The internal behavior remains unchanged (actually, since this even is bubbling up, it cannot physically affect the internal behavior). It just suggests the parent not to handle this event.
Thanks! |
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
🎉 Handy links: |
PR Checklist