Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another fix for the localtests, March 2021 edition #9660

Merged
2 commits merged into from
Mar 30, 2021
Merged

Another fix for the localtests, March 2021 edition #9660

2 commits merged into from
Mar 30, 2021

Commits on Mar 30, 2021

  1. This fixes part of the tests 

      Broadly, the tests were broken by #7489 because there were no _startupActions. They relied on the removed codepath that assumed wt.exe always set actions, or `AppCommandlineArgs::ValidateStartupCommands` created one by default.

  These tests are still broken:
  * `TerminalAppLocalTests::TabTests::TryZoomPane [Failed]`
  * `TerminalAppLocalTests::TabTests::MoveFocusFromZoomedPane [Failed]`
  * `TerminalAppLocalTests::TabTests::CloseZoomedPane [Failed]`

  Re:#9659
    @zadjii-msft
    zadjii-msft committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    06b4168 View commit details
    Browse the repository at this point in the history

  2. Make the comments clearer

    @zadjii-msft
    zadjii-msft committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    205eee7 View commit details
    Browse the repository at this point in the history