Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add logos to README #9925

Merged
merged 1 commit into from
Apr 28, 2021
Merged

doc: Add logos to README #9925

merged 1 commit into from
Apr 28, 2021
+2 −0

Conversation

cinnamon-msft
Copy link
Contributor

Summary of the Pull Request

Let's add our logos to our README to spice it up.

@zadjii-msft zadjii-msft added Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Second It's a PR that needs another sign-off labels Apr 26, 2021
miniksa
miniksa reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had personally thought this was going to be more like

LOGO "Windows Terminal"

(with Cascadia as the font of course) like some of the examples...

Not just all 3 logos.

@DHowett
Copy link
Member

DHowett commented Apr 26, 2021

I rather agree! I'd love to have a Windows Terminal banner 😄

@lhecker
Copy link
Member

lhecker commented Apr 27, 2021

I honestly like this version already and we can always improve on it later on.
But I'm also quite intrigued now in how a LOGO "Windows Terminal" version would look like as a comparison.
Either way: Nice!

DHowett
DHowett approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good enough for now.

@DHowett DHowett merged commit c95ed72 into main Apr 28, 2021
@DHowett DHowett deleted the cinnamon-msft-patch-2 branch April 28, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa left review comments

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@unrealapex unrealapex unrealapex approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cinnamon-msft @DHowett @lhecker @miniksa @zadjii-msft @unrealapex