Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azuredevops_serviceendpoint_azuredevops #349

Merged
merged 4 commits into from
Mar 31, 2021

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Mar 30, 2021

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

New resource azuredevops_serviceendpoint_azuredevops

Issue Number: #339

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3
Copy link
Collaborator Author

AccTest

==> Checking that code complies with gofmt requirements...
==> Sourcing .env file if avaliable
if [ -f .env ]; then set -o allexport; . ./.env; set +o allexport; fi; \
        TF_ACC=1 go test -tags "all" $(go list ./azuredevops/internal/acceptancetests |grep -v 'vendor') -v -run=TestAccServiceEndpointAzureDevOps -timeout 120m
=== RUN   TestAccServiceEndpointAzureDevOps_basic
=== PAUSE TestAccServiceEndpointAzureDevOps_basic
=== RUN   TestAccServiceEndpointAzureDevOps_complete
=== PAUSE TestAccServiceEndpointAzureDevOps_complete
=== RUN   TestAccServiceEndpointAzureDevOps_update
=== PAUSE TestAccServiceEndpointAzureDevOps_update
=== RUN   TestAccServiceEndpointAzureDevOps_RequiresImportErrorStep
=== PAUSE TestAccServiceEndpointAzureDevOps_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointAzureDevOps_basic
=== CONT  TestAccServiceEndpointAzureDevOps_update
=== CONT  TestAccServiceEndpointAzureDevOps_complete
=== CONT  TestAccServiceEndpointAzureDevOps_RequiresImportErrorStep
--- PASS: TestAccServiceEndpointAzureDevOps_complete (133.15s)
--- PASS: TestAccServiceEndpointAzureDevOps_RequiresImportErrorStep (134.29s)
--- PASS: TestAccServiceEndpointAzureDevOps_basic (137.45s)
--- PASS: TestAccServiceEndpointAzureDevOps_update (156.02s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        156.610s

@xuzhang3 xuzhang3 changed the title [WIP] New resource azuredevops_serviceendpoint_azuredevops New resource azuredevops_serviceendpoint_azuredevops Mar 31, 2021
@xuzhang3 xuzhang3 linked an issue Mar 31, 2021 that may be closed by this pull request
Comment on lines +139 to +144
project_id = azuredevops_project.project.id
service_endpoint_name = "%s"
description = "%s"
org_url = "https://dev.azure.com/myorganization"
release_api_url = "https://vsrm.dev.azure.com/myorganization"
personal_access_token = "0000000000000000000000000000000000000000000000000000"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you run terrafmt fmt ... for it, install: https://github.com/katbyte/terrafmt

@xuzhang3 xuzhang3 merged commit 18a3d25 into microsoft:master Mar 31, 2021
@xuzhang3 xuzhang3 deleted the f/serviceendpoint_azure_devops branch April 9, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: service endpoint for azure devops / tfs
2 participants