Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hashing From Service Endpoints #856

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Aug 15, 2023

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number:
Fork from #743.



=== RUN   TestAccServiceEndpointAzureRm_CreateAndUpdate
=== PAUSE TestAccServiceEndpointAzureRm_CreateAndUpdate
=== RUN   TestAccServiceEndpointAzureRm_MgmtGrpCreateAndUpdate
=== PAUSE TestAccServiceEndpointAzureRm_MgmtGrpCreateAndUpdate
=== RUN   TestAccServiceEndpointAzureRm_AutomaticCreateAndUpdate
=== PAUSE TestAccServiceEndpointAzureRm_AutomaticCreateAndUpdate
=== RUN   TestAccServiceEndpointAzureRm_WorkloadFederation_Manual_CreateAndUpdate
=== PAUSE TestAccServiceEndpointAzureRm_WorkloadFederation_Manual_CreateAndUpdate
=== RUN   TestAccServiceEndpointAzureRm_WorkloadFederation_Automatic_CreateAndUpdate
=== PAUSE TestAccServiceEndpointAzureRm_WorkloadFederation_Automatic_CreateAndUpdate
=== RUN   TestAccServiceEndpointAzureRm_ManagedServiceIdentity_CreateAndUpdate
=== PAUSE TestAccServiceEndpointAzureRm_ManagedServiceIdentity_CreateAndUpdate
=== CONT  TestAccServiceEndpointAzureRm_CreateAndUpdate
=== CONT  TestAccServiceEndpointAzureRm_WorkloadFederation_Manual_CreateAndUpdate
=== CONT  TestAccServiceEndpointAzureRm_ManagedServiceIdentity_CreateAndUpdate
=== CONT  TestAccServiceEndpointAzureRm_WorkloadFederation_Automatic_CreateAndUpdate
=== CONT  TestAccServiceEndpointAzureRm_AutomaticCreateAndUpdate
=== CONT  TestAccServiceEndpointAzureRm_MgmtGrpCreateAndUpdate
--- PASS: TestAccServiceEndpointAzureRm_MgmtGrpCreateAndUpdate (72.05s)
--- PASS: TestAccServiceEndpointAzureRm_WorkloadFederation_Manual_CreateAndUpdate (112.72s)
--- PASS: TestAccServiceEndpointAzureRm_ManagedServiceIdentity_CreateAndUpdate (113.65s)
--- PASS: TestAccServiceEndpointAzureRm_CreateAndUpdate (115.34s)
--- PASS: TestAccServiceEndpointAzureRm_AutomaticCreateAndUpdate (120.46s)
--- PASS: TestAccServiceEndpointAzureRm_WorkloadFederation_Automatic_CreateAndUpdate (186.47s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        191.420s

=== RUN   TestAccServiceEndpointAws_Basic
=== PAUSE TestAccServiceEndpointAws_Basic
=== RUN   TestAccServiceEndpointAws_Complete
=== PAUSE TestAccServiceEndpointAws_Complete
=== RUN   TestAccServiceEndpointAws_update
=== PAUSE TestAccServiceEndpointAws_update
=== RUN   TestAccServiceEndpointAws_requiresImportErrorStep
=== PAUSE TestAccServiceEndpointAws_requiresImportErrorStep
=== CONT  TestAccServiceEndpointAws_Basic
=== CONT  TestAccServiceEndpointAws_update
=== CONT  TestAccServiceEndpointAws_requiresImportErrorStep
=== CONT  TestAccServiceEndpointAws_Complete
--- PASS: TestAccServiceEndpointAws_Complete (61.15s)
--- PASS: TestAccServiceEndpointAws_Basic (70.87s)
--- PASS: TestAccServiceEndpointAws_requiresImportErrorStep (83.34s)
--- PASS: TestAccServiceEndpointAws_update (100.72s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        101.737s

=== RUN   TestAccServiceEndpointAzureDevOps_basic
=== PAUSE TestAccServiceEndpointAzureDevOps_basic
=== RUN   TestAccServiceEndpointAzureDevOps_complete
=== PAUSE TestAccServiceEndpointAzureDevOps_complete
=== RUN   TestAccServiceEndpointAzureDevOps_update
=== PAUSE TestAccServiceEndpointAzureDevOps_update
=== RUN   TestAccServiceEndpointAzureDevOps_RequiresImportErrorStep
=== PAUSE TestAccServiceEndpointAzureDevOps_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointAzureDevOps_basic
=== CONT  TestAccServiceEndpointAzureDevOps_update
=== CONT  TestAccServiceEndpointAzureDevOps_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointAzureDevOps_complete
--- PASS: TestAccServiceEndpointAzureDevOps_basic (59.37s)
--- PASS: TestAccServiceEndpointAzureDevOps_RequiresImportErrorStep (69.45s)
--- PASS: TestAccServiceEndpointAzureDevOps_complete (70.45s)
--- PASS: TestAccServiceEndpointAzureDevOps_update (103.22s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        104.527s

=== RUN   TestAccServiceEndpointBitBucket_basic
=== PAUSE TestAccServiceEndpointBitBucket_basic
=== RUN   TestAccServiceEndpointBitBucket_complete
=== PAUSE TestAccServiceEndpointBitBucket_complete
=== RUN   TestAccServiceEndpointBitBucket_update
=== PAUSE TestAccServiceEndpointBitBucket_update
=== RUN   TestAccServiceEndpointBitBucket_RequiresImportErrorStep
=== PAUSE TestAccServiceEndpointBitBucket_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointBitBucket_basic
=== CONT  TestAccServiceEndpointBitBucket_update
=== CONT  TestAccServiceEndpointBitBucket_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointBitBucket_complete
--- PASS: TestAccServiceEndpointBitBucket_complete (59.63s)
--- PASS: TestAccServiceEndpointBitBucket_basic (71.12s)
--- PASS: TestAccServiceEndpointBitBucket_RequiresImportErrorStep (81.96s)
--- PASS: TestAccServiceEndpointBitBucket_update (102.16s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        103.607s

=== RUN   TestAccServiceEndpointDockerRegistry_CreateAndUpdate
=== PAUSE TestAccServiceEndpointDockerRegistry_CreateAndUpdate
=== CONT  TestAccServiceEndpointDockerRegistry_CreateAndUpdate
--- PASS: TestAccServiceEndpointDockerRegistry_CreateAndUpdate (98.73s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        99.879s


=== RUN   TestAccServiceEndpointGeneric_basic
=== PAUSE TestAccServiceEndpointGeneric_basic
=== RUN   TestAccServiceEndpointGeneric_complete
=== PAUSE TestAccServiceEndpointGeneric_complete
=== RUN   TestAccServiceEndpointGeneric_update
=== PAUSE TestAccServiceEndpointGeneric_update
=== RUN   TestAccServiceEndpointGeneric_RequiresImportErrorStep
=== PAUSE TestAccServiceEndpointGeneric_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointGeneric_basic
=== CONT  TestAccServiceEndpointGeneric_update
=== CONT  TestAccServiceEndpointGeneric_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointGeneric_complete
--- PASS: TestAccServiceEndpointGeneric_complete (59.44s)
--- PASS: TestAccServiceEndpointGeneric_basic (69.32s)
--- PASS: TestAccServiceEndpointGeneric_RequiresImportErrorStep (81.08s)
--- PASS: TestAccServiceEndpointGeneric_update (98.12s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        99.260s

=== RUN   TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource
=== PAUSE TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource
=== RUN   TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource
=== PAUSE TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource
=== RUN   TestAccServiceEndpointGitHub_PersonalTokenBasic
=== PAUSE TestAccServiceEndpointGitHub_PersonalTokenBasic
=== RUN   TestAccServiceEndpointGitHub_PersonalTokenUpdate
=== PAUSE TestAccServiceEndpointGitHub_PersonalTokenUpdate
=== RUN   TestAccServiceEndpointGitHub_OauthBasic
=== PAUSE TestAccServiceEndpointGitHub_OauthBasic
=== RUN   TestAccServiceEndpointGitHub_OauthUpdate
=== PAUSE TestAccServiceEndpointGitHub_OauthUpdate
=== RUN   TestAccServiceEndpointGitHub_CreateAndUpdate
=== PAUSE TestAccServiceEndpointGitHub_CreateAndUpdate
=== CONT  TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource
=== CONT  TestAccServiceEndpointGitHub_OauthBasic
=== CONT  TestAccServiceEndpointGitHub_CreateAndUpdate
=== CONT  TestAccServiceEndpointGitHub_OauthUpdate
=== CONT  TestAccServiceEndpointGitHub_PersonalTokenBasic
=== CONT  TestAccServiceEndpointGitHub_PersonalTokenUpdate
=== CONT  TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource
--- PASS: TestAccServiceEndpointGitHub_PersonalTokenBasic (73.27s)
--- PASS: TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource (73.66s)
--- PASS: TestAccServiceEndpointGitHub_OauthBasic (74.20s)
--- PASS: TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource (74.31s)
--- PASS: TestAccServiceEndpointGitHub_OauthUpdate (115.90s)
--- PASS: TestAccServiceEndpointGitHub_PersonalTokenUpdate (115.91s)
--- PASS: TestAccServiceEndpointGitHub_CreateAndUpdate (117.12s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        118.088s

=== RUN   TestAccServiceEndpointGitHubEnterprise_PersonalTokenBasic
=== PAUSE TestAccServiceEndpointGitHubEnterprise_PersonalTokenBasic
=== RUN   TestAccServiceEndpointGitHubEnterprise_PersonalTokenUpdate
=== PAUSE TestAccServiceEndpointGitHubEnterprise_PersonalTokenUpdate
=== RUN   TestAccServiceEndpointGitHubEnterprise_CreateAndUpdate
=== PAUSE TestAccServiceEndpointGitHubEnterprise_CreateAndUpdate
=== CONT  TestAccServiceEndpointGitHubEnterprise_PersonalTokenBasic
=== CONT  TestAccServiceEndpointGitHubEnterprise_CreateAndUpdate
=== CONT  TestAccServiceEndpointGitHubEnterprise_PersonalTokenUpdate
--- PASS: TestAccServiceEndpointGitHubEnterprise_PersonalTokenBasic (63.60s)
--- PASS: TestAccServiceEndpointGitHubEnterprise_PersonalTokenUpdate (105.58s)
--- PASS: TestAccServiceEndpointGitHubEnterprise_CreateAndUpdate (110.34s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        111.973s

=== RUN   TestAccServiceEndpointIncomingWebhook_Basic
=== PAUSE TestAccServiceEndpointIncomingWebhook_Basic
=== RUN   TestAccServiceEndpointIncomingWebhook_Complete
=== PAUSE TestAccServiceEndpointIncomingWebhook_Complete
=== RUN   TestAccServiceEndpointIncomingWebhook_update
=== PAUSE TestAccServiceEndpointIncomingWebhook_update
=== RUN   TestAccServiceEndpointIncomingWebhook_requiresImportErrorStep
=== PAUSE TestAccServiceEndpointIncomingWebhook_requiresImportErrorStep
=== CONT  TestAccServiceEndpointIncomingWebhook_Basic
=== CONT  TestAccServiceEndpointIncomingWebhook_update
=== CONT  TestAccServiceEndpointIncomingWebhook_Complete
=== CONT  TestAccServiceEndpointIncomingWebhook_requiresImportErrorStep
--- PASS: TestAccServiceEndpointIncomingWebhook_Basic (60.37s)
--- PASS: TestAccServiceEndpointIncomingWebhook_Complete (62.35s)
--- PASS: TestAccServiceEndpointIncomingWebhook_requiresImportErrorStep (82.97s)
--- PASS: TestAccServiceEndpointIncomingWebhook_update (116.65s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        118.089s

=== RUN   TestAccServiceEndpointKubernetesForAzureSubscriptionCreateAndUpdate
=== PAUSE TestAccServiceEndpointKubernetesForAzureSubscriptionCreateAndUpdate
=== CONT  TestAccServiceEndpointKubernetesForAzureSubscriptionCreateAndUpdate
--- PASS: TestAccServiceEndpointKubernetesForAzureSubscriptionCreateAndUpdate (145.75s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        152.057s

=== RUN   TestAccServiceEndpointKubernetesForServiceAccountCreateAndUpdate
=== PAUSE TestAccServiceEndpointKubernetesForServiceAccountCreateAndUpdate
=== RUN   TestAccServiceEndpointKubernetesForKubeconfigCreateAndUpdate
=== PAUSE TestAccServiceEndpointKubernetesForKubeconfigCreateAndUpdate
=== CONT  TestAccServiceEndpointKubernetesForServiceAccountCreateAndUpdate
=== CONT  TestAccServiceEndpointKubernetesForKubeconfigCreateAndUpdate
--- PASS: TestAccServiceEndpointKubernetesForKubeconfigCreateAndUpdate (100.09s)
--- PASS: TestAccServiceEndpointKubernetesForServiceAccountCreateAndUpdate (100.52s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        101.955s

=== RUN   TestAccServiceEndpointRunPipeline_Defaults
=== PAUSE TestAccServiceEndpointRunPipeline_Defaults
=== RUN   TestAccServiceEndpointRunPipeline_PersonalTokenBasic
=== PAUSE TestAccServiceEndpointRunPipeline_PersonalTokenBasic
=== RUN   TestAccServiceEndpointRunPipeline_PersonalTokenUpdate
=== PAUSE TestAccServiceEndpointRunPipeline_PersonalTokenUpdate
=== CONT  TestAccServiceEndpointRunPipeline_Defaults
=== CONT  TestAccServiceEndpointRunPipeline_PersonalTokenUpdate
=== CONT  TestAccServiceEndpointRunPipeline_PersonalTokenBasic
--- PASS: TestAccServiceEndpointRunPipeline_Defaults (69.06s)
--- PASS: TestAccServiceEndpointRunPipeline_PersonalTokenBasic (69.75s)
--- PASS: TestAccServiceEndpointRunPipeline_PersonalTokenUpdate (100.02s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        101.079s

=== RUN   TestAccServiceEndpointSonarQube_basic
=== PAUSE TestAccServiceEndpointSonarQube_basic
=== RUN   TestAccServiceEndpointSonarQube_complete
=== PAUSE TestAccServiceEndpointSonarQube_complete
=== RUN   TestAccServiceEndpointSonarQube_update
=== PAUSE TestAccServiceEndpointSonarQube_update
=== RUN   TestAccServiceEndpointSonarQube_RequiresImportErrorStep
=== PAUSE TestAccServiceEndpointSonarQube_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointSonarQube_basic
=== CONT  TestAccServiceEndpointSonarQube_update
=== CONT  TestAccServiceEndpointSonarQube_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointSonarQube_complete
--- PASS: TestAccServiceEndpointSonarQube_complete (69.44s)
--- PASS: TestAccServiceEndpointSonarQube_basic (69.58s)
--- PASS: TestAccServiceEndpointSonarQube_RequiresImportErrorStep (79.62s)
--- PASS: TestAccServiceEndpointSonarQube_update (110.12s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        110.897s

=== RUN   TestAccServiceEndpointSSH_basic
=== PAUSE TestAccServiceEndpointSSH_basic
=== RUN   TestAccServiceEndpointSSH_complete
=== PAUSE TestAccServiceEndpointSSH_complete
=== RUN   TestAccServiceEndpointSSH_update
=== PAUSE TestAccServiceEndpointSSH_update
=== RUN   TestAccServiceEndpointSSH_RequiresImportErrorStep
=== PAUSE TestAccServiceEndpointSSH_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointSSH_basic
=== CONT  TestAccServiceEndpointSSH_update
=== CONT  TestAccServiceEndpointSSH_complete
=== CONT  TestAccServiceEndpointSSH_RequiresImportErrorStep
--- PASS: TestAccServiceEndpointSSH_complete (72.33s)
--- PASS: TestAccServiceEndpointSSH_basic (73.42s)
--- PASS: TestAccServiceEndpointSSH_RequiresImportErrorStep (82.43s)
--- PASS: TestAccServiceEndpointSSH_update (114.62s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        120.318s

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3 xuzhang3 merged commit 6f2445f into microsoft:main Aug 17, 2023
3 checks passed
@xuzhang3 xuzhang3 mentioned this pull request Aug 17, 2023
11 tasks
@xuzhang3 xuzhang3 added this to the v0.8.0 milestone Aug 17, 2023
@xuzhang3 xuzhang3 deleted the f/hashing-fixes branch October 23, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant