Skip to content

Commit

Permalink
Fix polycheck warnings (#3930)
Browse files Browse the repository at this point in the history
  • Loading branch information
Evangelink authored Oct 10, 2024
1 parent dcaa32a commit 15cd306
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ internal sealed partial class AppInsightsProvider :
#endif
#if DEBUG
// Telemetry properties that are allowed to contain unhashed information.
private static readonly HashSet<string> StringWhitelist =
private static readonly HashSet<string> KnownUnhashedProperties =
[
TelemetryProperties.VersionPropertyName,
TelemetryProperties.ReporterIdPropertyName,
Expand Down Expand Up @@ -111,7 +111,7 @@ public AppInsightsProvider(
_telemetryTask = task.Run(IngestLoopAsync, _testApplicationCancellationTokenSource.CancellationToken);
#else
// Keep the custom thread to avoid to waste one from thread pool.
// We have some await but we should stay on custom one if not for special needs like trace log or exception.
// We have some await but we should stay on the custom thread if not for special cases like trace log or exception.
_payloads = new();
_telemetryTask = _task.RunLongRunning(IngestLoopAsync, "Telemetry AppInsightsProvider", _testApplicationCancellationTokenSource.CancellationToken);
#endif
Expand Down Expand Up @@ -256,7 +256,7 @@ private static void AssertHashed(string key, string value)
return;
}

if (StringWhitelist.Contains(key))
if (KnownUnhashedProperties.Contains(key))
{
return;
}
Expand Down

0 comments on commit 15cd306

Please sign in to comment.