Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct exit code in case of cancellation and add OnExit phase for for IPushOnlyProtocol #3820

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

MarcoRossignoli
Copy link
Contributor

This pull request introduces several changes to improve the handling of test session cancellation and ensure proper disposal of resources in the Microsoft.Testing.Platform project. The most important changes include initializing the exitCode with a default failure value, handling the cancellation token in various parts of the RunAsync method, and adding a new method to the IPushOnlyProtocol interface.

Improvements to test session cancellation handling:

Resource disposal enhancements:

Interface and method additions:

@Evangelink Evangelink enabled auto-merge (squash) September 12, 2024 15:27
@Evangelink Evangelink merged commit 7b65d6d into microsoft:main Sep 12, 2024
7 checks passed
@MarcoRossignoli MarcoRossignoli deleted the dev/mr/nit branch October 4, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants