Ensure correct exit code in case of cancellation and add OnExit
phase for for IPushOnlyProtocol
#3820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve the handling of test session cancellation and ensure proper disposal of resources in the
Microsoft.Testing.Platform
project. The most important changes include initializing theexitCode
with a default failure value, handling the cancellation token in various parts of theRunAsync
method, and adding a new method to theIPushOnlyProtocol
interface.Improvements to test session cancellation handling:
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.cs
: InitializedexitCode
withExitCodes.GenericFailure
and added checks fortestApplicationCancellationToken.IsCancellationRequested
to setexitCode
toExitCodes.TestSessionAborted
when necessary. [1] [2]Resource disposal enhancements:
src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.cs
: Added afinally
block to callPushOnlyProtocol.OnExitAsync()
ifPushOnlyProtocol
is not null, ensuring proper cleanup.src/Platform/Microsoft.Testing.Platform/Hosts/CommonTestHost.cs
: UpdatedDisposeServiceProviderAsync
to continue if the service is anIPushOnlyProtocol
, ensuring it is not disposed prematurely.Interface and method additions:
src/Platform/Microsoft.Testing.Platform/ServerMode/IPushOnlyProtocol.cs
: Added theOnExitAsync
method to theIPushOnlyProtocol
interface.src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.cs
: Implemented theOnExitAsync
method to return a completed task.