Fix SelfRegisteredExtensions type to be internal #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bradwilson we need to internalize the service registration helper, as soon as this PR is merged can you give it a try with the nightly feed and let us know if it's breaking something on your side? |
MarcoRossignoli
approved these changes
Sep 30, 2024
|
@MarcoRossignoli What package version is this fixed in? I don't see it yet in |
|
No issues on my side. xunit/xunit@main...testfx-3891 |
|
Thank you @bradwilson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3813
I'll work on adding some acceptance test as a follow-up but I have manually tested against the demo project in the linked issue.