Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yy/mm to the log filename for better ordering #3894

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

MarcoRossignoli
Copy link
Contributor

closes #3751

@microsoft-github-policy-service microsoft-github-policy-service bot added Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Feature labels Sep 30, 2024
@MarcoRossignoli MarcoRossignoli marked this pull request as draft September 30, 2024 16:29
@MarcoRossignoli MarcoRossignoli marked this pull request as ready for review October 1, 2024 08:05
Marco Rossignoli added 2 commits October 1, 2024 10:29
@nohwnd
Copy link
Member

nohwnd commented Oct 1, 2024

Would be nice to have the year as yyyy, to make it easier to see that the first entry is a year.

I would also love some separators, but in the issue you said you want to keep it short.

Personally I would drop the fff part, it is very unlikely that we will create the same date + pid within the same second. You dropped the PID, so ignore this comment.

@MarcoRossignoli
Copy link
Contributor Author

MarcoRossignoli commented Oct 1, 2024

Would be nice to have the year as yyyy, to make it easier to see that the first entry is a year.

I don't see 2 more char useful if not making the filename longer, the pattern is explained in the --help. I think that as first step is enough, after I agree that we could add a way to have composable name including placeholder for date, tfm, pid and other interesting information.
Also I would not advice to enabled always the logs, we don't have scenario where "real issue" are not crashing or failing "clearly" the execution(no try/catch/go on) and so without log is hard to understand what's happened.

We can followup on it in future if we will have other users request. This one looks ok, the order by name is wrong.

@MarcoRossignoli MarcoRossignoli merged commit 0774431 into microsoft:main Oct 1, 2024
6 checks passed
@MarcoRossignoli MarcoRossignoli deleted the dev/mr/logfilename branch October 1, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add year, minute to the --diagnostic filename
2 participants