-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLCD2016 Tree Canopy #1243
base: main
Are you sure you want to change the base?
NLCD2016 Tree Canopy #1243
Conversation
torchgeo/datasets/nlcd.py
Outdated
class NLCD2016TreeCanopy(RasterDataset): | ||
"""National Land Cover Database 2016 (NLCD2016) - Tree Canopy dataset. | ||
|
||
The `National Land Cover Database <https://www.mrlc.gov/>`_ provides 30m tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would link to the tree canopy page, not the NLCD page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `National Land Cover Database <https://www.mrlc.gov/>`_ provides 30m tree | |
The `Multi-Resolution Land Characteristics (MRLC) Consortium <https://www.mrlc.gov/>`_ provides 30m tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the specific page for reference https://www.mrlc.gov/data/nlcd-2016-usfs-tree-canopy-cover-conus
torchgeo/datasets/nlcd.py
Outdated
class NLCD2016TreeCanopy(RasterDataset): | ||
"""National Land Cover Database 2016 (NLCD2016) - Tree Canopy dataset. | ||
|
||
The `National Land Cover Database <https://www.mrlc.gov/>`_ provides 30m tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the specific page for reference https://www.mrlc.gov/data/nlcd-2016-usfs-tree-canopy-cover-conus
Comparison of the IMG format to COG format:
|
Surprised img is faster than COGs, I thought COGs were the gold standard. |
This will need to be rebased once #1244 is merged. |
I'm guessing the difference is compression related (COG is 5x smaller and 3x slower to read). It is apples to oranges as if these were hosted on a remote server, you could still do windowed reading quickly with a COG. |
(for completeness, because I was curious)
Not quite actually, you can still do windowed reading from remote files with the Erdas Imagine format, but it is 2x slower than COGs. Also, compression vs. no compression doesn't seem to matter when reading from remote files (it looks like compressed is slightly faster, which makes sense as the time it takes to transfer the data is going to dominate). |
TL;DR -- use COGs |
We now have a generic |
This PR adds the NLCD2016 Tree Canopy dataset
See https://www.mrlc.gov/data/nlcd-2016-usfs-tree-canopy-cover-conus