Move requirements-min.txt, split deps in multiple files #605
Conversation
github-actions
bot
added
documentation
| @@ -36,7 +36,8 @@ jobs: | |||
| python-version: '3.10' | |||
| - name: Install pip dependencies | |||
| run: | | |||
| pip install -r requirements/requirements.txt | |||
| pip install --pre 'rasterio>=1.0.16' | |||
| pip install .[datasets,tests] | |||
There was a problem hiding this comment.
It's probably better to go back to installing from setup.cfg during release testing. We want to make sure this works since it's how actual PyPI installs will work.
| @@ -96,6 +96,8 @@ datasets = | |||
| # https://github.com/brianhelba/zipfile-deflate64/issues/19 | |||
| zipfile-deflate64>=0.2,<0.3 | |||
| docs = | |||
| # ipywidgets 7+ required by nbsphinx | |||
| ipywidgets>=7,<8 | |||
There was a problem hiding this comment.
I removed this in #574 (comment) because I couldn't remember why it was required and it didn't seem to be needed anymore. Turns out the addition of black[jupyter] installed ipywidgets behind the scenes, so that's why the tests didn't fail. Splitting things up into separate files uncovered spatialaudio/nbsphinx#24 (comment) which explains why I added this in the first place.
| open3d==0.14.1;python_version<'3.10' | ||
| opencv-python==4.6.0.66 | ||
| pandas==1.4.2;python_version>='3.8' | ||
| pandas==1.3.5;python_version=='3.7' |
There was a problem hiding this comment.
It's still unclear if dependabot will actually update lines like this, or if it will try to update both. Ideally, it would only update the first occurrence, or somehow parse the environment marker. If that doesn't work, we can create separate files for Python 3.7 (and 3.8 once numpy and friends drop that too).
|
Awesome, thanks for digging so far into this @adamjstewart! |
Turns out dependabot actually does support multiple files! I noticed this in #603 when it accidentally updated
requirements-min.txttoo. This PR does two things:requirements-min.txtto a subdirectory to avoid dependabot updatesrequirements.txtinto separate files for each CI stepIf
requirements/min/all.txtdoesn't avoid dependabot, I'll try moving it to a different directory.Splitting
requirements.txtinto separate files fulfills @weiji14's vision from #553! Style tests now take 15 s instead of 2 min.