Cache reads in RasterDataset #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebrob6
reviewed
Aug 16, 2021
| tensor: Tensor = torch.tensor(dest) # type: ignore[attr-defined] | ||
| return tensor | ||
|
|
||
| @functools.lru_cache(maxsize=128) |
There was a problem hiding this comment.
Hardcode cache size of 128 doesn't seem wise?
There was a problem hiding this comment.
Cache size doesn't actually matter here. We're caching file handles, not images. Each image is ~0.5 GB, but each file handle is tiny. GDAL has its own cache size that controls how large the cache actually is. Users can change this if they need to.
calebrob6
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #81 for design details.
This only covers RasterDataset, not VectorDataset. There's still a lot more that we could potentially do, but this is a good start.
I can't really test this without #84.