-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep trailing slash when building http routes #3737
Keep trailing slash when building http routes #3737
Conversation
All changed packages have been documented.
Show changes
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3737/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3737/ |
@timotheeguerin, I've tested my reproduction in the linked playground, and the problem is solved. Looking forward to this being released! I didn't realize this would mean introducing backward-incompatible changes, but that makes sense - thanks for the thoughtful consideration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timotheeguerin do we have a PR into typespec-next showing the impact?
You can try these changes here
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending breaking change review
fix #3350