replaces ${VERSION} variable with correct version in generated spdx files #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
reviewed
Aug 22, 2023
Co-authored-by: autoantwort <[email protected]>
ras0219-msft
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
This LGTM as a patch to the existing "hack" -- the long term fix is to have the helpers properly communicate their resources back to the tool.
@JulZimmermann We'd also really appreciate it if you'd be willing to share your use cases for the SBOM/SPDX files, either here on GitHub or via email at [email protected].
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for microsoft/vcpkg#28235