Fixed crash on non-existent port with version override #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error. We need to explicitly check if the returned registry entry is non-empty.
|
Thank you for the fix, this looks great! Could you also add an end-to-end test that verifies this behavior and prevents future regressions? It should hopefully be pretty straightforward to extend https://github.com/microsoft/vcpkg-tool/blob/main/azure-pipelines/end-to-end-tests-dir/registries.ps1 to cover this case. |
|
I added such a test. I verified that the un-fixed product failed:
|
BillyONeal
approved these changes
Mar 2, 2024
|
@microsoft-github-policy-service agree |
|
Thanks again for your help! |
|
Glad to be of help, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue reported in the vcpkg project:
microsoft/vcpkg#36994
The "entry" function does not return an error but an empty RegistryEntry in some situations, needs to be checked for.
An alternative solution would be to refactor all registry implementations to never return an empty RegistryEntry, but an error instead.
That should be done in a separate issue after this fix is merged.