Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften the 'use version rather than version-string' message. #1367

Merged
merged 2 commits into from
Apr 29, 2024

Commits on Mar 23, 2024

  1. Soften the 'use version rather than version-string' message.

    In microsoft/vcpkg#37563 (comment) we have an example of versions which meet the semantic versioning format but don't sort like semantic versions, so the message:
    
    ```console
    PS D:\vcpkg> .\vcpkg.exe x-add-version sqlite-modern-cpp
    Use the version scheme "version" rather than "version-string" in port "sqlite-modern-cpp".
    Use --skip-version-format-check to disable this check.
    ```
    
    is too strong. We need to explain to the user that they should only do that if the versions actually are intended to sort that way.
    BillyONeal committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    27764f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Change the message to explain how things work rather than assuming th…

    …e reader is familiar with semantic verisoning rules.
    BillyONeal committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d7dbd26 View commit details
    Browse the repository at this point in the history