Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrade] Don't crash on non-installed ports #1473

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

Thomas1664
Copy link
Contributor

Fixes microsoft/vcpkg#21117

output before:

error: The following packages are not installed:
  azure-storage-cpp:x64-windows
internal error: D:\a\_work\1\s\src\vcpkg\commands.upgrade.cpp(183): vcpkg has crashed; no additional details are available.
Please open an issue at https://github.com/microsoft/vcpkg/issues/new?template=other-type-of-bug-report.md&labels=category:vcpkg-bug with detailed steps to reproduce the problem.

output after:

error: The following packages are not installed:
  azure-storage-cpp:x64-windows

@GitMensch
Copy link

Not sure, just wondering: Would it be useful to issue a warning, then install?

(the goal would be a command that ensures you have the most current version, no matter if an old is installed or not)

@BillyONeal
Copy link
Member

@GitMensch I believe install --recurse has the behavior you want?

@BillyONeal
Copy link
Member

Ah, nope :/

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like this resolution because it's undoing what appears to be a very explicit attempt to emit all possible errors rather than stopping at the first error. Making a competing solution shortly...

@BillyONeal
Copy link
Member

image

Ouch it's even more broken

@Thomas1664
Copy link
Contributor Author

Ouch it's even more broken

I think that's a different issue.

I'm not sure I like this resolution because it's undoing what appears to be a very explicit attempt to emit all possible errors rather than stopping at the first error.

I restored emitting all errors.

@BillyONeal BillyONeal merged commit e720ee8 into microsoft:main Aug 29, 2024
6 checks passed
@BillyONeal
Copy link
Member

Thanks!

@Thomas1664 Thomas1664 deleted the fix-upgrade-crash branch August 30, 2024 05:50
BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this pull request Aug 31, 2024
BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this pull request Sep 4, 2024
BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this pull request Sep 18, 2024
Removes the hack added in microsoft#1477
Tests the condition fixed by microsoft#1473
BillyONeal added a commit that referenced this pull request Sep 19, 2024
Removes the hack added in #1477
Tests the condition fixed by #1473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcpkg upgrade] vcpkg has crashed (update on not installed packages)
3 participants