-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pipeline/e2e] end-to-end-tests.ps1 should fail with failure test #1518
base: main
Are you sure you want to change the base?
[pipeline/e2e] end-to-end-tests.ps1 should fail with failure test #1518
Conversation
86eeba9
to
7755480
Compare
adf8f06
to
29bce0b
Compare
TestExample of un-expected pass before fixed Example of failed as expected after fixed |
fbd9d4b
to
90476ce
Compare
35a4312
to
4ecab71
Compare
As far as I can tell it already does this. Do you have a repro for it not doing so? (EDIT: I see you have an example in a comment here but it's not clear how you got that to happen) |
It looks like the repro might only happen with something like this "Pester" module ( as in #1512 ) because all other existing e2e tests fail by throwing an exception, thus stopping further test runs. |
Fix
end-to-end-tests.ps1
, which should fail and stop with failure test case.Change
Pester
for e2e testsaction/checkout@4
,actions/setup-node@v4
,lukka/[email protected]
macos-12
tomacos-13
macOS 12
Actions runner image will begin deprecation on 10/7/24 and will be fully unsupported by 12/3/24 for GitHub and ADO actions/runner-images#10721Invoke-Pester
for*.Tests.ps1
inend-to-end-tests.ps1
$LASTEXITCODE
$LASTEXITCODE
forThrow-IfNotFailed
Run-VcpkgAndCaptureOutput
autocomplete-command.ps1
Throw-IfNotFailed
for non-windows