Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipeline/e2e] end-to-end-tests.ps1 should fail with failure test #1518

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Oct 21, 2024

Fix end-to-end-tests.ps1, which should fail and stop with failure test case.

Change

@WangWeiLin-MV WangWeiLin-MV force-pushed the e2e/fix-case-error-forwarding branch 5 times, most recently from 86eeba9 to 7755480 Compare October 21, 2024 07:58
@WangWeiLin-MV WangWeiLin-MV changed the title [e2e] Test end-to-end-tests.ps1 [e2e] end-to-end-tests.ps1 should fail with failure test Oct 21, 2024
@WangWeiLin-MV WangWeiLin-MV force-pushed the e2e/fix-case-error-forwarding branch 2 times, most recently from adf8f06 to 29bce0b Compare October 21, 2024 08:44
@WangWeiLin-MV WangWeiLin-MV changed the title [e2e] end-to-end-tests.ps1 should fail with failure test [pipeline/e2e] end-to-end-tests.ps1 should fail with failure test Oct 21, 2024
@WangWeiLin-MV
Copy link
Contributor Author

WangWeiLin-MV commented Oct 21, 2024

@WangWeiLin-MV WangWeiLin-MV force-pushed the e2e/fix-case-error-forwarding branch 5 times, most recently from fbd9d4b to 90476ce Compare October 21, 2024 11:19
@BillyONeal
Copy link
Member

BillyONeal commented Oct 21, 2024

Fix end-to-end-tests.ps1, which should fail and stop with failure test case.

As far as I can tell it already does this. Do you have a repro for it not doing so?

(EDIT: I see you have an example in a comment here but it's not clear how you got that to happen)

@BillyONeal
Copy link
Member

It looks like the repro might only happen with something like this "Pester" module ( as in #1512 ) because all other existing e2e tests fail by throwing an exception, thus stopping further test runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants