Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore packages from nuget if X_VCPKG_NUGET_ID_PREFIX set #192

Merged
merged 2 commits into from
Oct 4, 2021
Merged

restore packages from nuget if X_VCPKG_NUGET_ID_PREFIX set #192

merged 2 commits into from
Oct 4, 2021

Conversation

ctapmex
Copy link
Contributor

@ctapmex ctapmex commented Sep 11, 2021

After #40 we can set different prefixes for caching packages in nuget. It's working fine for push to cache. But restore from cache don`t working:

  1. nuget download package with prefix from cache
  2. but vcpkg don't see him - Restored 0 packages from NuGet. Use --debug for more information.

fix microsoft/vcpkg#19095 and microsoft/vcpkg#19103

ras0219-msft
ras0219-msft approved these changes Sep 12, 2021
View reviewed changes
src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
src/vcpkg/binarycaching.cpp Outdated Show resolved Hide resolved
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

@strega-nil-ms
Copy link
Contributor

Given that @ras0219 approves, merging! Thanks @ctapmex :)

@strega-nil-ms strega-nil-ms merged commit 89d20d4 into microsoft:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use X_VCPKG_NUGET_ID_PREFIX for download packages
3 participants
@ctapmex @ras0219-msft @strega-nil-ms