Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "vcpkg configure environment" release pipeline and subcommands. #277

Merged
merged 29 commits into from
Dec 3, 2021

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Nov 19, 2021

This adds the "vcpkg configure environment" formerly-separate-product commands to vcpkg. "vcpkg-ce", formerly "Project Cella" formerly "Project Northfield" is an incubating separate product to get vcpkg solving for all build time dependencies, including tooling, rather than only sources. Initial releases touching these commands will be in a very rough "collect feedback" state, and the commands may be changed or removed at any time. (Completely separating from the vcpkg command proper is still a possible outcome, for example)

This change incorporates many peoples' work, not only my own, and will not be squashed. In particular, but not limited to:

The new release process if there are updates to the "configure environment" components is:

  1. Update the azure-pipelines/vcpkg-ce-sha.txt to whatever is desired from microsoft/vcpkg-ce
  2. git fetch origin && git push internal origin/main:main, which kicks off producing the signed builds as described here in azure-pipelines/signing.yml. This ensures that things signed by Microsoft are actually from Microsoft.
  3. The push above will automatically kick off https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build?definitionId=13610 which will create a draft release in this repo. Example: https://github.com/microsoft/vcpkg-tool/releases/tag/2021-11-18
  4. If OK, publish the release created by the previous step.
  5. Create a PR updating the date and relevant SHAs in microsoft/vcpkg (for example Update tool to 2021-11-15. vcpkg#21471 )

@BillyONeal BillyONeal force-pushed the dev/bion/fetch-ce branch 3 times, most recently from ffb510e to 9fa245b Compare November 20, 2021 03:55
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to post these earlier, so my apologies if they don't line up with the current files.

CMakeLists.txt Outdated Show resolved Hide resolved
azure-pipelines/arch-independent-signing.signproj Outdated Show resolved Hide resolved
azure-pipelines/signing.yml Show resolved Hide resolved
include/vcpkg/commands.version.h Show resolved Hide resolved
include/vcpkg/commands.version.h Show resolved Hide resolved
src/vcpkg/archives.cpp Outdated Show resolved Hide resolved
src/vcpkg/archives.cpp Show resolved Hide resolved
include/vcpkg/archives.h Outdated Show resolved Hide resolved
src/vcpkg/base/system.process.cpp Outdated Show resolved Hide resolved
src/vcpkg/commands.format-manifest.cpp Show resolved Hide resolved
@BillyONeal BillyONeal force-pushed the dev/bion/fetch-ce branch 4 times, most recently from 4ddad43 to 15034d3 Compare November 30, 2021 23:59
@BillyONeal BillyONeal marked this pull request as ready for review December 2, 2021 03:07
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting revert of the vcpkg list breaking changes before merge

include/vcpkg/archives.h Outdated Show resolved Hide resolved
include/vcpkg/base/system.process.h Outdated Show resolved Hide resolved
include/vcpkg/commands.new.h Outdated Show resolved Hide resolved
include/vcpkg/commands.zbootstrap-standalone.h Outdated Show resolved Hide resolved
include/vcpkg/configuration.h Outdated Show resolved Hide resolved
src/vcpkg/configure-environment.cpp Outdated Show resolved Hide resolved
src/vcpkg/tools.cpp Outdated Show resolved Hide resolved
src/vcpkg/vcpkgcmdarguments.cpp Outdated Show resolved Hide resolved
vcpkg-init/lock-versions.ps1 Outdated Show resolved Hide resolved
vcpkg-init/lock-versions.ps1 Outdated Show resolved Hide resolved
@BillyONeal BillyONeal merged commit a4ffba5 into main Dec 3, 2021
@BillyONeal BillyONeal deleted the dev/bion/fetch-ce branch December 3, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants