Constexprify unicode #696
Merged
Constexprify unicode #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Sep 8, 2022
include/vcpkg/base/messages.h
Outdated
| @@ -1580,6 +1580,7 @@ namespace vcpkg | |||
| "'--' at the beginning must be preserved", | |||
| "-- Using community triplet {triplet}. This triplet configuration is not guaranteed to succeed."); | |||
| DECLARE_MESSAGE(UsingManifestAt, (msg::path), "", "Using manifest file at {path}."); | |||
| DECLARE_MESSAGE(Utf8DecoderDereferencedAtEof, (), "", "dereferenced Utf8Decoder at the end of a string."); | |||
There was a problem hiding this comment.
This is a program bug rather than a user message so I don't think it should be localized. (Maybe in all such cases we should be outright deleting the message and adding a comment to the line instead? /cc @JavierMatosD )
BillyONeal
reviewed
Sep 8, 2022
BillyONeal
reviewed
Sep 8, 2022
BillyONeal
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many functions inside
unicode.handunicode.cppcould be marked asconstexpr.