Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for error, warning, and message in vcpkg-configuration.json. #733

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

BillyONeal
Copy link
Member

$ type .\vcpkg-configuration.json
{
  "default-registry": { /* ... */ },
  "registries": [ /* ... */ ],
  "demands": {
    "example:hello": {
      "error": "example:hello matched"
    },
    "example:world and x86": {
      "error": "example:world & x86 matched"
    },
    "example:world and x64": {
      "error": "example:world & x64 matched"
    },
    "arm": {
      "error": "arm matched"
    }
  }
}
$ vcpkg activate --example hello
warning: vcpkg-artifacts are experimental and may change at any time.
ERROR: c:\Dev\test\vcpkg-configuration.json - example:hello matched
$ vcpkg activate --example world
warning: vcpkg-artifacts are experimental and may change at any time.
ERROR: c:\Dev\test\vcpkg-configuration.json - example:world & x64 matched
$ vcpkg activate --example world --x86
warning: vcpkg-artifacts are experimental and may change at any time.
ERROR: c:\Dev\test\vcpkg-configuration.json - example:world & x86 matched
$ vcpkg activate --arm
warning: vcpkg-artifacts are experimental and may change at any time.
ERROR: c:\Dev\test\vcpkg-configuration.json - arm matched

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Oct 8, 2022
This change documents the world after these land:
* microsoft/vcpkg-tool#731 deletes --project in favor of --x-manifest-root
* microsoft/vcpkg-tool#732 fixes warning messages to say vcpkg-artifacts instead of vcpkg-ce
* microsoft/vcpkg-tool#733 fixes emitting warnings from vcpkg-configuration.json
* microsoft/vcpkg-tool#734 deletes the almost unused --verbose

The following are added here:

* acquire
* acquire-project
* activate
* add
* deactivate
* use

--language and --allLanguages are intentionally undocumented for now while we figure out what we want to do with localization.

Remaining issues I haven't fixed I noticed while doing this:
* Artifacts doesn't appear to understand & or | in demands
* `vcpkg use` doesn't work with deactivate
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like something that should be tested, otherwise LGTM.

@BillyONeal
Copy link
Member Author

I agree. Unfortunately we have no way to do e2e testing of artifacts right now or I would have added one.

@BillyONeal BillyONeal merged commit 5f284a2 into microsoft:main Oct 10, 2022
@BillyONeal BillyONeal deleted the project-demands branch October 10, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants