Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Port Request] bddisasm #16982

Closed
ianichitei opened this issue Mar 31, 2021 · 5 comments
Closed

[New Port Request] bddisasm #16982

ianichitei opened this issue Mar 31, 2021 · 5 comments
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. info:new-port-resolved This port has been added to vcpkg.

Comments

@ianichitei
Copy link
Contributor

Library name: bddisasm

Library description: x86/x86_64 instruction decoder and emulator

Source repository URL: https://github.com/bitdefender/bddisasm

Anything else that is useful to know when adding (such as optional features the library may have that should be included):

I've already prepared a port here, but the contributing guidelines recommend opening an issue to discuss the port, instead of opening directly a PR.

I've tested the port with GCC and Clang on Linux and MSVC on Windows when building with CMake. I also checked the MSBuild integration with Visual Studio 2019 16.7.1. Everything seems to work, but I'm not entirely sure if I did everything right in the portfile.
@NancyLi1013 NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. labels Apr 1, 2021
@JonLiu1993 JonLiu1993 added the info:versioning This PR or Issue pertains to the versioning feature label Apr 2, 2021
@JackBoosY JackBoosY removed the info:versioning This PR or Issue pertains to the versioning feature label Apr 2, 2021
@aizuon
Copy link
Contributor

aizuon commented Apr 12, 2021

bddisasm is an interesting library that i wanted to use in some of my projects for quite a while but because it wasnt supported by vcpkg, i never had the opportunity. Thank you for your contribution!

@ianichitei
Copy link
Contributor Author

bddisasm is an interesting library that i wanted to use in some of my projects for quite a while but because it wasnt supported by vcpkg, i never had the opportunity. Thank you for your contribution!

I'm glad to here that. Writing the port was a good motivation for modernizing some aspects of our build scripts :)

@ianichitei
Copy link
Contributor Author

Any updates on this? Is there anything I can/should do?

@PhoebeHui
Copy link
Contributor

@ianichitei, could you submit a PR for this?

@ianichitei ianichitei mentioned this issue May 21, 2021
Merged
@NancyLi1013
Copy link
Contributor

Thanks for posting this request and also for your PR @ianichitei.
Closing this issue for now since this port has been added to vcpkg.

@NancyLi1013 NancyLi1013 added the info:new-port-resolved This port has been added to vcpkg. label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. info:new-port-resolved This port has been added to vcpkg.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@PhoebeHui @aizuon @NancyLi1013 @JackBoosY @ianichitei @JonLiu1993