Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libwebp] build failure #17359

Closed
larshg opened this issue Apr 19, 2021 · 10 comments
Closed

[libwebp] build failure #17359

larshg opened this issue Apr 19, 2021 · 10 comments
Assignees
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support

Comments

@larshg
Copy link
Contributor

larshg commented Apr 19, 2021

Host Environment

  • OS: Windows x64
  • Compiler: VS2019

To Reproduce
Using a triplet file, where only release library is build
./vcpkg install libwebp[core,nearlossless,simd,unicode]:x64-windows-rel

Failure logs


CMake Error at scripts/cmake/vcpkg_replace_string.cmake:13 (file):
  file failed to open for reading (No such file or directory):

    C:/vcpkg/packages/libwebp_x64-windows-rel/debug/lib/pkgconfig/libwebp.pc
Call Stack (most recent call first):
  ports/libwebp/portfile.cmake:64 (vcpkg_replace_string)
  scripts/ports.cmake:142 (include)

https://dev.azure.com/PointCloudLibrary/pcl/_build/results?buildId=18719&view=logs&j=645d9b2d-e6a8-55a6-fe5b-40842942afe7&t=07185e79-ad4d-5c13-c1d1-201b01637442&l=4141

Additional context
Probably due to hard coded paths in this:

85a48c1#diff-b7fda08137df905438eca706b25d715b4ceb70d81c9f7c9d3c485c726931b406R64-R68

@JonLiu1993 JonLiu1993 added the requires:repro The issue is not currently repro-able label Apr 20, 2021
@JonLiu1993
Copy link
Member

JonLiu1993 commented Apr 20, 2021

@larshg ,Are you using the latest vcpkg?

@larshg
Copy link
Contributor Author

larshg commented Apr 20, 2021

Its run with master from two days ago, however the hardcoded paths are still in master:

vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/debug/lib/pkgconfig/libwebp.pc" "-lwebp" "-lwebpd")

And its set to only build release version, so there shouldnt be any debug folder nor files in it.

@JonLiu1993 JonLiu1993 added category:question This issue is a question and removed requires:repro The issue is not currently repro-able labels Apr 20, 2021
@JonLiu1993
Copy link
Member

@larshg ,Thanks for your issue,Currently, we do not support a single relase or debug install

@cenit
Copy link
Contributor

cenit commented Apr 20, 2021

@larshg ,Thanks for your issue,Currently, we do not support a single relase or debug install

the pity is that libwebp was working in a release only triplet before, so it's always a problem when things go in the wrong direction if left by themselves...

@cenit
Copy link
Contributor

cenit commented Apr 20, 2021

as @larshg , i also have some ci pipelines that are now broken due to this change.

#15983 for me is very important. I hope it can be reconsidered soon, to avoid problems like this

@dg0yt
Copy link
Contributor

dg0yt commented Apr 21, 2021

Fixed waiting in #17172...

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support and removed category:question This issue is a question labels May 8, 2021
@JackBoosY
Copy link
Contributor

@dg0yt #17172 was already merged, can you please open a PR to fix this?

Thanks.

@JackBoosY JackBoosY added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label May 8, 2021
@dg0yt
Copy link
Contributor

dg0yt commented May 8, 2021

@JackBoosY @larshg IMO #17172 fixed this issue.

@larshg
Copy link
Contributor Author

larshg commented May 8, 2021

Yes, thanks. I'll close this - I haven't verified it however. This will probably happen over the weekend 😄

@larshg larshg closed this as completed May 8, 2021
@larshg
Copy link
Contributor Author

larshg commented May 8, 2021

Just looked at some docker buildlogs and it does build now, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

5 participants