Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libwebp] Fix release-only builds #17172

Merged
merged 3 commits into from
Apr 30, 2021
Merged

[libwebp] Fix release-only builds #17172

merged 3 commits into from
Apr 30, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 9, 2021

Describe the pull request

  • What does your PR fix?
    This PR makes it possible to build libwebp with VCPKG_BUILD_TYPE "release". Error before this change:
-- Building x86-windows-rel
CMake Error at scripts/cmake/vcpkg_replace_string.cmake:13 (file):
  file failed to open for reading (No such file or directory):

    D:/a/1/s/packages/libwebp_x86-windows/debug/lib/pkgconfig/libwebp.pc
Call Stack (most recent call first):
  ports/libwebp/portfile.cmake:64 (vcpkg_replace_string)
  scripts/ports.cmake:142 (include)

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All triplets, in particular with VCPKG_BUILD_TYPE added.

  • Does your PR follow the maintainer guide?
    -/-

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Apr 9, 2021
@JackBoosY
Copy link
Contributor

Please get failure logs here.

JackBoosY
JackBoosY suggested changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the port version. See documentation.
Also please run command vcpkg x-add-version --all then commit the changes.

@dg0yt dg0yt mentioned this pull request Apr 10, 2021
Closed
@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 10, 2021

All changes done.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 11, 2021
@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 19, 2021

What is needed to move this forward?

@dg0yt dg0yt changed the title Fix release-only builds of libwebp [libwebp] Fix release-only builds Apr 19, 2021
@JackBoosY
Copy link
Contributor

@dg0yt Nope.
@strega-nil Ping for review and merge this PR.

@dg0yt dg0yt mentioned this pull request Apr 21, 2021
Closed
@strega-nil-ms
Copy link
Contributor

Thanks @dg0yt :)

@strega-nil-ms strega-nil-ms merged commit 369e139 into microsoft:master Apr 30, 2021
@dg0yt dg0yt deleted the libwebp branch December 12, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @JackBoosY @strega-nil-ms