[skia] Build failure on arm64-osx-dynamic #41971
Comments
|
We reduced this in Ladybird to an error in skia's gn files I have a patch locally that I'm testing that looks like so: diff --git a/bazel/exporter_tool/main.go b/bazel/exporter_tool/main.go
index 7d08bba939..e0ce13509a 100644
--- a/bazel/exporter_tool/main.go
+++ b/bazel/exporter_tool/main.go
@@ -614,12 +614,10 @@ var gniExportDescs = []exporter.GNIExportDesc{
{GNI: "modules/skparagraph/skparagraph.gni", Vars: []exporter.GNIFileListExportDesc{
{Var: "skparagraph_public",
Rules: []string{
- "//modules/skparagraph/include:hdrs",
- "//modules/skparagraph/utils:utils_hdrs"}},
+ "//modules/skparagraph/include:hdrs"}},
{Var: "skparagraph_sources",
Rules: []string{
- "//modules/skparagraph/src:srcs",
- "//modules/skparagraph/utils:utils_srcs"}},
+ "//modules/skparagraph/src:srcs"}},
{Var: "skparagraph_utils",
Rules: []string{
"//modules/skparagraph/utils:utils_hdrs",
diff --git a/modules/skparagraph/skparagraph.gni b/modules/skparagraph/skparagraph.gni
index 1356b5dc8a..b9caea20b9 100644
--- a/modules/skparagraph/skparagraph.gni
+++ b/modules/skparagraph/skparagraph.gni
@@ -11,9 +11,7 @@
_modules = get_path_info("../../modules", "abspath")
-# List generated by Bazel rules:
-# //modules/skparagraph/include:hdrs
-# //modules/skparagraph/utils:utils_hdrs
+# Generated by Bazel rule //modules/skparagraph/include:hdrs
skparagraph_public = [
"$_modules/skparagraph/include/DartTypes.h",
"$_modules/skparagraph/include/FontArguments.h",
@@ -27,12 +25,9 @@ skparagraph_public = [
"$_modules/skparagraph/include/TextShadow.h",
"$_modules/skparagraph/include/TextStyle.h",
"$_modules/skparagraph/include/TypefaceFontProvider.h",
- "$_modules/skparagraph/utils/TestFontCollection.h",
]
-# List generated by Bazel rules:
-# //modules/skparagraph/src:srcs
-# //modules/skparagraph/utils:utils_srcs
+# Generated by Bazel rule //modules/skparagraph/src:srcs
skparagraph_sources = [
"$_modules/skparagraph/src/Decorations.cpp",
"$_modules/skparagraph/src/Decorations.h",
@@ -58,7 +53,6 @@ skparagraph_sources = [
"$_modules/skparagraph/src/TextWrapper.cpp",
"$_modules/skparagraph/src/TextWrapper.h",
"$_modules/skparagraph/src/TypefaceFontProvider.cpp",
- "$_modules/skparagraph/utils/TestFontCollection.cpp",
]
# List generated by Bazel rules:This diff makes |
|
Is this an issue with newest XCode/SDK? The vcpkg port is not up-to-date. Maybe it was already fixed upstream. (Why have The vcpkg port runs only |
Cheney-W
added
requires:repro
|
The change to the bazel/go files is simply to ensure that the autogenerated .gni files (skparagraph.gni) match what is created by the upstream tooling. I plan to submit that patch upstream soon ™️. This issue is present when using a debug+dynamic linking triplet like so: set(VCPKG_CMAKE_SYSTEM_NAME Darwin)
set(VCPKG_TARGET_ARCHITECTURE arm64)
set(VCPKG_OSX_ARCHITECTURES arm64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)But doesn't show up when using VCPKG_LIBRARY_LINKAGE static. |
|
...oh... You effectively reported it for the official triplet (static, tested in CI), but the issue shows for the |
|
That's interesting. I used the recommended |
ADKaster
changed the title
Cheney-W
added
the
category:community-triplet
Package: skia[core,fontconfig,freetype,gl,harfbuzz,icu,metal]:arm64-osx@129
Host Environment
vcpkg-scripts version: 10b7a17 2024-10-21 (2 weeks ago)
To Reproduce
vcpkg install --no-print-usageFailure logs
/Users/andrew/Source/ladybird-browser/Build/vcpkg/buildtrees/skia/build-arm64-osx-dbg-out.log
Additional context
vcpkg.json
The text was updated successfully, but these errors were encountered: