Meta: Use dynamic vcpkg linkage for release builds #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trflynn89
force-pushed
the
vcpkg_shared
branch
4 times, most recently
from
07deb06
to
23f2d5f
Compare
trflynn89
force-pushed
the
vcpkg_shared
branch
5 times, most recently
from
458676e
to
c2fe12e
Compare
ADKaster
force-pushed
the
vcpkg_shared
branch
from
c2fe12e
to
0b90a52
Compare
|
I rebased this and bumped the simdutf version, hopefully this satisfies the github action cache enough to let this move forward and unblock Alex's GPU work |
|
The cache action thing was basically avoided by the commit to bump to the October release. The ongoing issue is that skia doesn't build. |
|
Pushed a workaround for microsoft/vcpkg#41971 |
This is a fix to the vcpkg package itself to fix some exported symbols.
ADKaster
force-pushed
the
vcpkg_shared
branch
from
b6236c2
to
51a779d
Compare
Using install(IMPORTED_RUNTIME_ARTIFACTS), we can re-export the shared library and frameworks we imported from outside the build tree into our install treer. This is required for simdutf as it is a dependency of the AK library, and we need liblagom-ak.so to be loadable when doing fuzzer and cross-compile builds for the Lagom tools.
The reason for this change is that CMake/vcpkg are unable to detect a change to VCPKG_LIBRARY_LINKAGE. So when we switch to dynamic builds, the switch would be non-functional, and every developer would have to remove their Build and vcpkg cache directories manually. By changing these directories, vcpkg is able to detect it must rebuild.
In addition to changing the build-type dependent build directories, we can take this opportunity to move the vcpkg cache directory to the Build folder itself. This probably isn't 100% needed, but it ensures that no leftover artifacts are used from non-dynamic vcpkg builds, and it's also generally nice to have all build artifacts under Build.
By using static linkage, we are opening ourselves up to ODR violations that result in runtime crashes (rather than build-time link errors). For example, we've seen this happen while trying to use Skia context in both LibGfx and LibWeb.
With luck, this will blast the old vcpkg cache for simdutf in github actions and allow us to move forward with the new dynamic linking support.
This works around an issue in upstream skia where a debug build with dynamic libraries includes an extra file in the skparagraph module that is not compilable on macOS.
ADKaster
force-pushed
the
vcpkg_shared
branch
from
51a779d
to
3effe05
Compare
|
Let's go with this and deal with the fallout. :marge: |
|
This seems to have broken the artifact created by $ cd ladybird-js-Linux-x86_64
$ ls lib
liblagom-ak.so liblagom-coreminimal.so.0.0.0 liblagom-js.so.0 liblagom-syntax.so liblagom-unicode.so.0.0.0
liblagom-ak.so.0 liblagom-crypto.so liblagom-js.so.0.0.0 liblagom-syntax.so.0 liblagom-url.so
liblagom-ak.so.0.0.0 liblagom-crypto.so.0 liblagom-line.so liblagom-syntax.so.0.0.0 liblagom-url.so.0
liblagom-core.so liblagom-crypto.so.0.0.0 liblagom-line.so.0 liblagom-textcodec.so liblagom-url.so.0.0.0
liblagom-core.so.0 liblagom-filesystem.so liblagom-line.so.0.0.0 liblagom-textcodec.so.0
liblagom-core.so.0.0.0 liblagom-filesystem.so.0 liblagom-regex.so liblagom-textcodec.so.0.0.0
liblagom-coreminimal.so liblagom-filesystem.so.0.0.0 liblagom-regex.so.0 liblagom-unicode.so
liblagom-coreminimal.so.0 liblagom-js.so liblagom-regex.so.0.0.0 liblagom-unicode.so.0
$ ldd bin/js | grep '=> not found' | grep -v 'libstdc++'
libsimdutf.so.11 => not found
libicui18n.so.74 => not found
libicuuc.so.74 => not found
$ |
|
Also affects test262.fyi: https://github.com/test262-fyi/test262.fyi/actions/runs/11733811717/job/32688786826 |
|
Should be fixed by #2225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.