Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I add a new port #8823

Closed
ig-or opened this issue Oct 31, 2019 · 4 comments
Closed

How do I add a new port #8823

ig-or opened this issue Oct 31, 2019 · 4 comments
Assignees
Labels
category:question This issue is a question

Comments

@ig-or
Copy link
Contributor

ig-or commented Oct 31, 2019

Hello, I have a quite general question. I was thinking about adding a port to some library. But since this library is not supported on all the platforms/configurations, I added a number of "vcpkg_fail_port_install" in the portfile.cmake file, as was suggested #8602 (comment)

Now this port tells "Some checks were not successful" : https://github.com/microsoft/vcpkg/pull/8628l

Is this an expected behavior? Should the port pass all the checks in order to be integrated? Should every port support all the platforms/configurations? If it is possible not to support all the configurations, then then what is the correct way to handle this?

Best regards, Igor

@ig-or ig-or added the category:question This issue is a question label Oct 31, 2019
@JackBoosY
Copy link
Contributor

JackBoosY commented Oct 31, 2019

Hi @ig-or, thanks join us as our contributor! We already have documentation and examples, please see these links.
And we will pay attention with you PR.

Thanks.

@JackBoosY
Copy link
Contributor

Does this issue still bother you?

@ig-or
Copy link
Contributor Author

ig-or commented Dec 31, 2019 via email

@JackBoosY
Copy link
Contributor

JackBoosY commented Feb 19, 2020

If this issue is still not resolved, please reopen it.

BTW, I tried to improve the process of adding ports in #9430.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:question This issue is a question
Projects
None yet
Development

No branches or pull requests

2 participants