Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fcl] Update to 0.6.0 #10025

Merged
merged 2 commits into from
Mar 10, 2020
Merged

[fcl] Update to 0.6.0 #10025

merged 2 commits into from
Mar 10, 2020

Conversation

NancyLi1013
Copy link
Contributor

Update to 0.6.0 and remove patches.

Related issue #10013

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Feb 11, 2020
@PhoebeHui
Copy link
Contributor

fcl failed on CI, could you take a look?

@NancyLi1013
Copy link
Contributor Author

NancyLi1013 commented Feb 17, 2020 •
edited
Loading

The failures on fcl are like this:

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
C:/vsts/_work/4/s/buildtrees/fcl/src/11f588cb82-a00892d54e/src/EIGEN3_INCLUDE_DIR
   used as include directory in directory C:/vsts/_work/4/s/buildtrees/fcl/src/11f588cb82-a00892d54e/src

Since fcl needs to depend on eigen3 on version 0.6.0.

@NancyLi1013
Copy link
Contributor Author

/azp run

@NancyLi1013 NancyLi1013 marked this pull request as ready for review February 26, 2020 04:44
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Feb 26, 2020
@strega-nil
Copy link
Contributor

This is awesome, thanks @NancyLi1013 :)

@strega-nil strega-nil merged commit 39079db into microsoft:master Mar 10, 2020
Toxe pushed a commit to Toxe/vcpkg that referenced this pull request Mar 11, 2020
@NancyLi1013 @Toxe
[fcl] Update to 0.6.0 (microsoft#10025)
a08e7ac 
* [fcl] Update to 0.6.0

* Add dependency eigen
Toxe added a commit to Toxe/vcpkg that referenced this pull request Mar 11, 2020
@Toxe
Revert "[fcl] Update to 0.6.0 (microsoft#10025)"
1524e6a 
This reverts commit a08e7ac.
@traversaro traversaro mentioned this pull request Oct 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NancyLi1013 @PhoebeHui @strega-nil