-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mozjpeg] fix build #12118
Merged
Merged
[mozjpeg] fix build #12118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build worked in CI but conflicts with |
ras0219
reviewed
Jun 27, 2020
LilyWangL
approved these changes
Jun 29, 2020
LilyWangL
added
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
labels
Jun 29, 2020
# Conflicts: # scripts/ci.baseline.txt
ras0219-msft
approved these changes
Jul 8, 2020
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
hellozee
pushed a commit
to hellozee/vcpkg
that referenced
this pull request
Sep 11, 2020
* fix mozjpeg build * re-disable in CI baseline * fix static install * rename static libs, add pkgconfig fixup * update version string Co-authored-by: Billy Robert O'Neal III <[email protected]> Co-authored-by: Robert Schumacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes multiple build/install issues in current mozjpeg port
What does your PR fix?
Adds dependency for
libpng
, which resolves the following error on-static
triplets:Fixes invalid use of
vcpkg_copy_tools
, which resolves the following error:Fixes a typo in the CMake options that led to both static and dynamic outputs in
-static
triplets.Renames the lib files to remove
-static
from the file names, as is done forlibjpeg-turbo
.Adds
pkgconfig
fixups.Cleans up patch to make only minimal changes.
Which triplets are supported/not supported? Have you updated the CI baseline?
Tested with
x86-windows
x86-windows-static
x64-windows
x64-windows-static
x64-linux
Updated CI baseline to enable these tripletsDoes your PR follow the maintainer guide?
Looks like it