Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fltk] Force static library due to global variables. Fix CMake Targets. #12273

Merged
merged 4 commits into from
Jul 31, 2020
Merged

[fltk] Force static library due to global variables. Fix CMake Targets. #12273

merged 4 commits into from
Jul 31, 2020

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Jul 6, 2020

See title.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 6, 2020
strega-nil
strega-nil suggested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only thing I see :)

ports/fltk/CONTROL Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui mentioned this pull request Jul 14, 2020
Closed
@PhoebeHui PhoebeHui self-assigned this Jul 14, 2020
@PhoebeHui
Copy link
Contributor

The bin folder need to remove.

Failures on OSX:

-- Performing post-build validation
There should be no bin\ directory in a static build, but /Users/vagrant/Data/packages/fltk_x64-osx/bin is present.
There should be no debug\bin\ directory in a static build, but /Users/vagrant/Data/packages/fltk_x64-osx/debug/bin is present.
If the creation of bin\ and/or debug\bin\ cannot be disabled, use this in the portfile to remove them

if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
    file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin")
endif()

Found 1 error(s). Please correct the portfile:
/Volumes/data/work/1/s/ports/fltk/portfile.cmake
-- Performing post-build validation done
Error: Building package fltk:x64-osx failed with: POST_BUILD_CHECKS_FAILED
Elapsed time for package fltk:x64-osx: 1.072 min

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 22, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 7938ab7 into microsoft:master Jul 31, 2020
@StarGate-One StarGate-One mentioned this pull request Jul 31, 2020
Closed
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@ras0219 @ras0219-msft
@strega-nil @PhoebeHui @hellozee
[fltk] Force static library due to global variables. Fix CMake Target…
87e2e6b 
…s. (microsoft#12273)

* [fltk] Force static library due to global variables. Fix CMake Targets.

* [fltk] Add include directory to exported targets

* [fltk] Update ports/fltk/CONTROL

Co-authored-by: nicole mazzuca <[email protected]>

* Update ports/fltk/portfile.cmake

Co-authored-by: Robert Schumacher <[email protected]>
Co-authored-by: nicole mazzuca <[email protected]>
Co-authored-by: Phoebe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@PhoebeHui PhoebeHui

@LilyWangL LilyWangL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ras0219 @PhoebeHui @strega-nil @LilyWangL @JackBoosY @ras0219-msft