Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[curl] Fix tools #12758

Merged
merged 1 commit into from
Aug 7, 2020
Merged

[curl] Fix tools #12758

merged 1 commit into from
Aug 7, 2020

Conversation

NancyLi1013
Copy link
Contributor

vcpkg_copy_tool_dependencies cannot copy dll files to the destinations, so update it as vcpkg_copy_tools().

Note: feature tools has passed with the following triplets:

  • x86-windows
  • x64-windows

Other features are no need to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 5, 2020
@cenit
Copy link
Contributor

cenit commented Aug 5, 2020

Also, one less patch to maintain, thanks to a proper usage of vcpkg built-ins!

@NancyLi1013 NancyLi1013 marked this pull request as ready for review August 6, 2020 01:28
@NancyLi1013
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

Related: #12276.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 7, 2020
@NancyLi1013 NancyLi1013 mentioned this pull request Aug 7, 2020
Merged
@strega-nil strega-nil merged commit 23fcc57 into microsoft:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to execute curl.exe after building curl[tool]:x64-windows
4 participants
@NancyLi1013 @cenit @JackBoosY @strega-nil