[tensorflow] upgrade to 2.4.1 #16364
Conversation
jgehw
commented
Feb 22, 2021
•
jgehw
commented
- upgrade tensorflow to 2.4.1
…se customized bazel config is stored in wrong directory
- add patch to fix debug builds - add patch to fix exports for static linking - really build debug (instead of cloning release) - override bazel build options for debug (work around bazel bug) - bazel doesn't support static libraries: work around by building dynamic library and constructing static linkage commands from build log - Windows .pdb file can't be >4GB even on x64: work around using reduced debug information - Windows doesn't support .lib files >4GB even on x64, so split into multiple libs - vcpkg requires equal amount of libs for debug and release: work around using handcrafted empty dummy libs - fix naming of libs (.dll on Windows and .dylib on macOS)
- adapt patch files to tensorflow code changes - update bazel from v0.25.2 to v3.1 - on Windows use python installed on the host instead of embedded python obtained via vcpkg because embedded python lacks pip, which we need to obtain numpy - on Windows add MSYS2 to the PATH so that bazel tools can access MSYS2 GIT - add support for custom CA certificates when using HTTPS_PROXY
The existing implementation totally screwed up commands if the command's arguments contained semicolons (this is the case, e.g., in the FindPython modules of the cmake distribution).
…tually are use cases for this
incorporate changes from microsoft:master
…-more' as required for find_package(Python3)
Revert "incorporate changes from microsoft:master"
…eading the last real libraries contents over the required number of libraries
…/vcpkg into fix-static-builds-and-more
… python) for Windows as we need numpy
|
@NancyLi1013 as the TensorFlow UWP branch won't get merged in the foreseeable future, I removed the UWP changes from this PR, so that it only contains the TensorFlow v2.3.1 -> v2.4.1 upgrade now, so you can remove the "depends:different-pr" label. Contents of this PR are now just a) removal of patches that were merged upstream and b) new patches that got necessary. |
NancyLi1013
removed
the
depends:different-pr
|
Is this PR ready for review now? |
@NancyLi1013 yes, please |
NancyLi1013
changed the title
Co-authored-by: NancyLi1013 <[email protected]>
|
@NancyLi1013 please trigger a full Linux build, then the CI should build fine. The current CI error is because there were still files from the previous build: |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
added
info:reviewed
|
After rerun, all CI checks have passed now. LGTM, thanks for your update @jgehw. |
|
Converting to draft while this PR is blocked on another. |
@ras0219-msft It's no longer blocked as I reverted the UWP specific changes on March 2nd. Afterwards, this PR has already been reviewed by @NancyLi1013, so it's actually ready for merge into master. |
|
Relate to UWP PR #14394 |
|
@vicroms, since this doesn't include the uwp changes any more, could you help review and merge this PR? |
|
Thanks, this looks great to me! |
