Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yasm-tool] Migrate to Host Dependencies #16478

Merged
merged 4 commits into from
May 21, 2021
Merged

[yasm-tool] Migrate to Host Dependencies #16478

merged 4 commits into from
May 21, 2021

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Mar 1, 2021 •
edited
Loading

This allows mpg123, nettle, and gmp to support non-x86 windows manifest mode

fixes #15087

Depends on #16627

Depends on #16660

@strega-nil strega-nil added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 1, 2021
@strega-nil strega-nil mentioned this pull request Mar 1, 2021
Merged
@strega-nil strega-nil marked this pull request as draft March 1, 2021 20:38
@strega-nil
Copy link
Contributor Author

Marked as draft since it should be modified to use CURRENT_HOST_INSTALLED_DIR

@microsoft microsoft deleted a comment from azure-pipelines bot Mar 9, 2021
@strega-nil
Copy link
Contributor Author

Cancelling to wait for the cache to get filled by CI in #16627

@strega-nil
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil marked this pull request as ready for review March 10, 2021 23:34
strega-nil
strega-nil commented Mar 11, 2021
View reviewed changes
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@strega-nil strega-nil marked this pull request as draft March 11, 2021 19:44
@strega-nil strega-nil mentioned this pull request Mar 11, 2021
Closed
@strega-nil strega-nil force-pushed the yasm-tool-host branch 2 times, most recently from b4c9315 to 000969e Compare March 12, 2021 21:44
@strega-nil strega-nil marked this pull request as ready for review March 12, 2021 22:01
@StarGate-One StarGate-One mentioned this pull request Mar 12, 2021
Closed
@PhoebeHui PhoebeHui mentioned this pull request Mar 15, 2021
Closed
@PhoebeHui PhoebeHui self-assigned this Mar 16, 2021
@PhoebeHui PhoebeHui mentioned this pull request Mar 16, 2021
Merged
@strega-nil strega-nil changed the title [yasm-tool] Change to a host-only port [yasm-tool] fix usage Mar 16, 2021
@BillyONeal BillyONeal mentioned this pull request May 3, 2021
Closed
@JackBoosY JackBoosY linked an issue May 3, 2021 that may be closed by this pull request
[yasm-tool:x64-windows] build failure #17627
Closed
@dg0yt dg0yt mentioned this pull request May 5, 2021
Closed
@cenit
Copy link
Contributor

cenit commented May 7, 2021

This really needs the "native" constraint, since it requires being able to use binaries produced in the build. Marking as draft for now.

i don't see PR as draft now. Can you please explain this point more? We have some blocking issues depending on this and I might help you if I can in any way

@JackBoosY
Copy link
Contributor

Yeah... this issue blocked many ports now.

@mgsutton
Copy link

Any more movement on this yasm issue? Just updated vcpkg and now I'm broken.

@strega-nil
Copy link
Contributor Author

sorry about letting this go for a bit, it needed a tool update; now that that's happened, I'm working on doin' a merge

@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
[yasm-tool] Fix usage of port to be host dependencies
08a04d2 
This allows mpg123, nettle, and gmp to support non-x86 windows manifest mode
@strega-nil
fix gmp
1f89430
@mgsutton
Copy link

I hate to continue to pester, but it looks like the checks submitted by @strega-nil are passing. Are there additonal requirements for this PR to be accepted? yasm is breaking gmp and mpfr which are breaking cgal on x64-windows for me. Thanks for the efforts to fix this.

PhoebeHui
PhoebeHui approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VincentRouvreau VincentRouvreau mentioned this pull request May 19, 2021
Closed
@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY mentioned this pull request May 20, 2021
Merged
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 20, 2021
@wrobelda
Copy link
Contributor

wrobelda commented May 20, 2021 •
edited
Loading

#18029 also depends on it for x64 Windows builds (tested and can confirm it works as expected)

@strega-nil-ms strega-nil-ms merged commit 49b67d9 into microsoft:master May 21, 2021
@PhoebeHui PhoebeHui mentioned this pull request May 26, 2021
Merged
@strega-nil strega-nil deleted the yasm-tool-host branch June 30, 2021 17:36
@acgetchell acgetchell mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenit cenit cenit approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

@vicroms vicroms vicroms approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
10 participants
@strega-nil @JackBoosY @cenit @PhoebeHui @mgsutton @strega-nil-ms @wrobelda @BillyONeal @vicroms @ras0219-msft