-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yasm-tool] Migrate to Host Dependencies #16478
Conversation
Marked as draft since it should be modified to use |
5b4197e
to
6edff11
Compare
Cancelling to wait for the cache to get filled by CI in #16627 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
6edff11
to
fa92bbb
Compare
b4c9315
to
000969e
Compare
i don't see PR as draft now. Can you please explain this point more? We have some blocking issues depending on this and I might help you if I can in any way |
Yeah... this issue blocked many ports now. |
Any more movement on this yasm issue? Just updated vcpkg and now I'm broken. |
sorry about letting this go for a bit, it needed a tool update; now that that's happened, I'm working on doin' a merge |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
1719ad7
to
ffc9c9f
Compare
This allows mpg123, nettle, and gmp to support non-x86 windows manifest mode
ffc9c9f
to
1f89430
Compare
I hate to continue to pester, but it looks like the checks submitted by @strega-nil are passing. Are there additonal requirements for this PR to be accepted? yasm is breaking gmp and mpfr which are breaking cgal on x64-windows for me. Thanks for the efforts to fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
#18029 also depends on it for x64 Windows builds (tested and can confirm it works as expected) |
This allows mpg123, nettle, and gmp to support non-x86 windows manifest mode
fixes #15087
Depends on #16627Depends on #16660