-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kf5codecs] new port #16561
[kf5codecs] new port #16561
Conversation
Seems you need to rebase this PR now, many changes were brought in this PR. Or you can open a new pull request to adding this port. |
4e1dd13
to
ab7ca64
Compare
@NancyLi1013 should be ready. The |
Seems there is something wrong with the patch file disable_tests_enable_static_build.patch. We might need to patch it in another way.
|
6ffffd6
to
2fa505c
Compare
@NancyLi1013 addressed all of the issues and rebased. |
Can you merge master to this PR? @wrobelda It seems that there is no |
Yes, I literally just found out about this 🤦🏻♂️. No clue how that happened. Fixing. EDIT: Fixed. |
c246a17
to
da58f47
Compare
LGTM now, except for the problem caused by |
@NancyLi1013 I rebased to pick-up a fix for #18116, but CI/CD seems stuck. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Let's wait for the new CI test result. |
Awesome, thanks again @wrobelda :) |
Describe the pull request
Adds new kf5codecs port.
Which triplets are supported/not supported? Have you updated the CI baseline?
All official should be supported.
Does your PR follow the maintainer guide?
Yes