-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fastor] add new port Fastor #16587
[Fastor] add new port Fastor #16587
Conversation
Since the upstream port provides a cmake config, IMO you should install it with cmake and fixup the targets. |
ports/fastor/portfile.cmake
Outdated
HEAD_REF master | ||
) | ||
|
||
file(COPY ${SOURCE_PATH}/Fastor DESTINATION ${CURRENT_PACKAGES_DIR}/include/${PORT}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also CMakeLists.txt in the source code. So it would be better to use vcpkg_configure_cmake()
and vcpkg_install_cmake()
to build and install this port.
Hi @Hoikas and @NancyLi1013, |
Hmm... Considering how helpful cmake targets are, it might be best to use the latest commit and set the port's version to today's date. |
Is it possible to port the package without cmake for now? When that repo publishes a new tag we can write a new port with cmake. |
Convert to draft until the upstream changes. Please ping me if it is ready for review. |
Hi @duanqn Could you please update to the latest commit that contains CMakeLists.txt for this PR? |
@duanqn , Is this PR being worked on? Could you update pr based on nancy's suggestion? |
88e0625
to
02ae6c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for fastor but no changes to version or port version.
-- Version: 0.6.3
-- Old SHA: ea69d44e4460ca4392581532c10e519c033fa3e1
-- New SHA: f9bce91121c3bf19d7b66bdef894cc5d5029e408
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/fastor/portfile.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for fastor but no changes to version or port version.
-- Version: 2021-11-22
-- Old SHA: 5ba530e20d9adca2f9cda32b6685d8ee66242650
-- New SHA: 13267b1928216a11e9d09fc497290df5b5691144
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for fastor but no changes to version or port version.
-- Version: 2021-11-22
-- Old SHA: 5ba530e20d9adca2f9cda32b6685d8ee66242650
-- New SHA: 24b3fc4241eb82555225352893d2bd9dc14e17a1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
@JonLiu1993 Thanks for notifying me. Please see if the current port meets the requirement. |
e7e1f0e
to
37aace6
Compare
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for fastor but no changes to version or port version.
-- Version: 2021-11-22
-- Old SHA: 24b3fc4241eb82555225352893d2bd9dc14e17a1
-- New SHA: b01ca4e019955e95abc9338e07aaa076d989c8d3
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for fastor but no changes to version or port version.
-- Version: 2021-11-22
-- Old SHA: 24b3fc4241eb82555225352893d2bd9dc14e17a1
-- New SHA: 6437d1dc343d2b061f0c6414fce30b72b4e1e889
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for fastor but no changes to version or port version.
-- Version: 2021-11-22
-- Old SHA: 24b3fc4241eb82555225352893d2bd9dc14e17a1
-- New SHA: 9db673c173f5c27fc113f35837767d9d815e2976
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Thanks for the new port! |
Describe the pull request
What does your PR fix? Fixes [New Port Request] Fastor #16532
Which triplets are supported/not supported? Have you updated the CI baseline?
It is a header-only library. I'm assuming it supports all triplets. CI baseline has been updated.
Does your PR follow the maintainer guide?
Yes.