[FLANN] Allow to be build as shared lib #16724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
the
category:port-feature
|
Please get failure logs here. |
larshg
force-pushed
the
AllowSharedFlann
branch
4 times, most recently
from
48af59d
to
0f10c6e
Compare
|
@JackBoosY Should I include corrections to pcl, openmvg and others in this PR as well? |
|
@larshg Please fix them in another PR. |
larshg
force-pushed
the
AllowSharedFlann
branch
5 times, most recently
from
9a4e452
to
c92c5c7
Compare
Closed
larshg
force-pushed
the
AllowSharedFlann
branch
from
c92c5c7
to
9231e5c
Compare
JackBoosY
added
the
depends:different-pr
|
The build error on Ubuntu is:
Doesn't seem to have anything with FLANN to do? |
JackBoosY
removed
the
depends:different-pr
|
I can't repro this issue on my machine, here is my log: Yours: |
With this PR merged? So it fails on CI, but not on your local PC?
|
|
Glib is not a dependency of openmvg or one of its dependency chains, I am curious why it is linked to glib. Edit: no difference between the configure logs. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The openmvg:x64-linux failed with following failure in CI testing and will be fixed by #16954 |
JackBoosY
added
depends:different-pr
|
Sorry for late, I will handle it this week. |
|
I have rebased it and hopefully updated accordingly with control files to json conversion. Edit: Just realized that I haven't done it for FLANN itself. |
JackBoosY
suggested changes
May 6, 2021
larshg
force-pushed
the
AllowSharedFlann
branch
2 times, most recently
from
510ab6b
to
876502e
Compare
|
I have updated the flann cuda project settings, as it missed a define. |
|
I have added the possibility to enable the cuda build. |
larshg
force-pushed
the
AllowSharedFlann
branch
2 times, most recently
from
7f0a8e5
to
1594c3c
Compare
|
When installing now it correctly tells: In static: |
JackBoosY
suggested changes
May 7, 2021
JackBoosY
suggested changes
May 8, 2021
JackBoosY
approved these changes
May 10, 2021
JackBoosY
added
info:reviewed
|
This LGTM! Thanks @larshg :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Allow FLANN to build as shared library.
Which triplets are supported/not supported? Have you updated the CI baseline?
All triplets.
versions/baseline.json is updated with new version.
Does your PR follow the maintainer guide? Yes.