Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HarfBuzz] Update Port to 2.8.1 #17273

Merged
merged 18 commits into from
May 21, 2021
Merged

[HarfBuzz] Update Port to 2.8.1 #17273

merged 18 commits into from
May 21, 2021

Conversation

kirawi
Copy link
Contributor

@kirawi kirawi commented Apr 13, 2021

Describe the pull request
Updates HarfBuzz to 2.8.1

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No change

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@ghost
Copy link

ghost commented Apr 13, 2021

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this Apr 14, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 14, 2021
@kirawi
Copy link
Contributor Author

kirawi commented Apr 14, 2021

REGRESSION: paraview:x86-windows. If expected, add paraview:x86-windows=fail to .\scripts\ci.baseline.txt. I'm confused.

Copy link
Member

@JonLiu1993 JonLiu1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirawi,please Keep the format of patch2 correct

@JonLiu1993
Copy link
Member

JonLiu1993 commented Apr 14, 2021

@kirawi ,please take a look :

CMake Error at D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
  Could NOT find Gettext (missing: GETTEXT_MSGMERGE_EXECUTABLE
  GETTEXT_MSGFMT_EXECUTABLE)

@JonLiu1993
Copy link
Member

The another failures caused by popsift will be fixed by #17277.

CMake Error at ports/popsift/portfile.cmake:9 (include):
  include could not find load file:

    D:/installed/x64-windows/share/vcpkg_find_cuda/vcpkg_find_cuda.cmake

@kirawi
Copy link
Contributor Author

kirawi commented Apr 14, 2021

@kirawi,please Keep the format of patch2 correct

Sorry, could you elaborate on this as well as the CMake error you commented? I'm afraid I don't quite understand. I also applied the changes you requested, but I'm having trouble getting versions/h-/harfbuzz.json to update with vcpkg x-add-version harfbuzz. It simply does not update, even after deleting the entry that's currently there in this PR.

On a new clone of the main repo, these were the steps I followed to get the same result:

  1. Update ports/harfbuzz/portfile.cmake, ports/harfbuzz/vcpkg.json, and versions/baseline.json with the same changes here.
  2. Apply the changes you requested, and change the value of port-version in versions/baseline.json to 0.
  3. Run vcpkg x-add-version --all.

However, I'm also getting the same result even if I apply the exact same changes in the PR as it is now... I must be missing a step here that I followed when I originally opened the PR. I apologize, I'm not familiar with these tools or the C/C++ toolkit.

@JonLiu1993
Copy link
Member

@kirawi ,Sometimes the error in CI may not be the problem of the port you modified, it may be caused by the port you rely on or other port errors on CI. At present, all CI problems have been fixed, and your pr is ready to merge.

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response info:reviewed Pull Request changes follow basic guidelines labels Apr 15, 2021
@JonLiu1993
Copy link
Member

@kirawi ,please modify the content I marked, and then I can mark review

@kirawi
Copy link
Contributor Author

kirawi commented Apr 18, 2021

All checks have passed.

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 19, 2021
@strega-nil-ms
Copy link
Contributor

@kirawi can you merge with latest?

@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kirawi
Copy link
Contributor Author

kirawi commented May 6, 2021

Looks like x64_windows froze on marble[core], and x64_windows_static_md failed to build opencv4 and kf5itemviews. CI is not an easy beast to work with ^_^

@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kirawi
Copy link
Contributor Author

kirawi commented May 10, 2021

x86_windows failed on an unrelated port.

@kirawi
Copy link
Contributor Author

kirawi commented May 11, 2021

All checks have passed.

@PhoebeHui
Copy link
Contributor

@dan-shaw, could you help merge this PR?

@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label May 18, 2021
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 20, 2021
@kirawi
Copy link
Contributor Author

kirawi commented May 20, 2021

I'll go ahead and bump the version to 2.8.1

@kirawi kirawi changed the title [HarfBuzz] Update to 2.8.0 [HarfBuzz] Update Port to 2.8.1 May 20, 2021
@JonLiu1993 JonLiu1993 added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels May 21, 2021
@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 21, 2021
@dan-shaw dan-shaw merged commit 9c23718 into microsoft:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants