-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HarfBuzz] Update Port to 2.8.1 #17273
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirawi,please Keep the format of patch2 correct
@kirawi ,please take a look :
|
The another failures caused by popsift will be fixed by #17277.
|
Sorry, could you elaborate on this as well as the CMake error you commented? I'm afraid I don't quite understand. I also applied the changes you requested, but I'm having trouble getting On a new clone of the main repo, these were the steps I followed to get the same result:
However, I'm also getting the same result even if I apply the exact same changes in the PR as it is now... I must be missing a step here that I followed when I originally opened the PR. I apologize, I'm not familiar with these tools or the C/C++ toolkit. |
@kirawi ,Sometimes the error in CI may not be the problem of the port you modified, it may be caused by the port you rely on or other port errors on CI. At present, all CI problems have been fixed, and your pr is ready to merge. |
@kirawi ,please modify the content I marked, and then I can mark review |
All checks have passed. |
@kirawi can you merge with latest? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks like x64_windows froze on marble[core], and x64_windows_static_md failed to build |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
x86_windows failed on an unrelated port. |
All checks have passed. |
@dan-shaw, could you help merge this PR? |
I'll go ahead and bump the version to 2.8.1 |
Describe the pull request
Updates HarfBuzz to 2.8.1
Which triplets are supported/not supported? Have you updated the CI baseline?
No change
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes