Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing autoconf dependencies to Linux provisioning #17278

Closed
wants to merge 1 commit into from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 14, 2021

  • What does your PR fix?

This PR is to install dependencies which are required by autoconf when building ports such as libtasn1 or libidn2. The lack of these dependencies breaks a number of PRs (e.g. #17215, #17205, #17137, #17098, #17057).
It is broken out of #17227 (which is osx only now)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    linux, -/-

  • Does your PR follow the maintainer guide?

    -/-

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    -/-

@JackBoosY JackBoosY added the depends:vm-update PR contains changes to the VM provisioning scripts label Apr 14, 2021
@JackBoosY
Copy link
Contributor

depends on #17277

@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 24, 2021

Repeating from #17227:
Today I would rather propose to not merge this. It solves issues in CI but not for users, and better solutions start to get merged.

@JackBoosY
Copy link
Contributor

@dg0yt So please close this issue or change it to draft.

@dg0yt dg0yt closed this Apr 24, 2021
@dg0yt dg0yt deleted the linux-provisioning branch December 12, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends:vm-update PR contains changes to the VM provisioning scripts info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants