[Boost] fix not header only libs #17372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
added
the
category:port-feature
|
@autoantwort, thanks for your PR! Boost-json failed with following failures in CI pipeline, could you please take a look? |
You can fix this issue with the following post-source script: file(READ "${SOURCE_PATH}/build/Jamfile" _contents)
string(REPLACE "import ../../config/checks/config" "import config/checks/config" _contents "${_contents}")
file(WRITE "${SOURCE_PATH}/build/Jamfile" "${_contents}")
file(READ "${SOURCE_PATH}/Jamfile" _contents)
string(REPLACE "import ../config/checks/config" "import build/config/checks/config" _contents "${_contents}")
file(WRITE "${SOURCE_PATH}/Jamfile" "${_contents}")
file(COPY "${CURRENT_INSTALLED_DIR}/share/boost-config/checks" DESTINATION "${SOURCE_PATH}/build/config")But then you get other errors and I have no clue how to fix them |
|
I have asked at the boost json lib, maybe they can and are willing to help: boostorg/json#556 |
|
@PhoebeHui you can review now :) |
PhoebeHui
reviewed
May 6, 2021
There was a problem hiding this comment.
LGTM, @ras0219-msft, could you please help further review?
cc @yurybura
PhoebeHui
approved these changes
May 7, 2021
|
@dan-shaw, could you help review and merge this PR? |
yurybura
suggested changes
May 13, 2021
yurybura
approved these changes
May 13, 2021
strega-nil-ms
suggested changes
May 25, 2021
Co-authored-by: nicole mazzuca <[email protected]>
ras0219-msft
requested changes
May 26, 2021
Co-authored-by: Robert Schumacher <[email protected]>
JackBoosY
suggested changes
May 27, 2021
JackBoosY
approved these changes
May 28, 2021
|
Thanks for your work @autoantwort :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [boost-json] Fails to build static library #16907
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes