Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[catch2] updated catch2 to version 2.13.6 #17435

Merged
merged 10 commits into from
May 21, 2021

Conversation

georg-emg
Copy link
Contributor

I updated the version in the catch2 port to 2.13.6. I also replaced the old CONTROL file with a proper manifest.

Georg Schwab added 2 commits April 22, 2021 09:56
- replaces catch2 CONTROL file with proper manifest
@NancyLi1013 NancyLi1013 self-assigned this Apr 22, 2021
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 22, 2021
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you forgot to update portfile.cmake file.

ports/catch2/vcpkg.json Outdated Show resolved Hide resolved
versions/c-/catch2.json Outdated Show resolved Hide resolved
@georg-emg
Copy link
Contributor Author

georg-emg commented Apr 22, 2021

It seems that you forgot to update portfile.cmake file.

Only took me three tries to fix! (I hope)

@georg-emg georg-emg marked this pull request as ready for review April 23, 2021 06:37
ports/catch2/vcpkg.json Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 20, 2021
@dan-shaw dan-shaw merged commit 2f99720 into microsoft:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants