Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[matplotplusplus] Fix find and use dependencies #17552

Merged
merged 2 commits into from
Apr 30, 2021
Merged

[matplotplusplus] Fix find and use dependencies #17552

merged 2 commits into from
Apr 30, 2021

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Apr 28, 2021 •
edited
Loading

Fixes the following dependencies:

  • libjpeg-turbo
  • tiff
  • zlib and libpng
  • lapack
  • blas
  • fftw3
  • opencv

Fixes #17416.

Already test all features on x64-windows.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 28, 2021
@JackBoosY
Copy link
Contributor Author

@SKNo Can you please test this PR?

Thanks.

@JackBoosY
Copy link
Contributor Author

Waiting for #17528 merge.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 28, 2021
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 29, 2021
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 30, 2021
@strega-nil-ms strega-nil-ms merged commit 8dad905 into microsoft:master Apr 30, 2021
@JackBoosY JackBoosY deleted the dev/jack/17416_1 branch May 2, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[matplot++] <requires nodesoup and fftw3[threads]>
3 participants
@JackBoosY @NancyLi1013 @strega-nil-ms