[openh264] only build shared or static library #17592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Currently, when installing openh264, both the static and shared library get built and potentially installed, even though only a static or shared one is requested by vcpkg. For example, on x64-linux:
This PR incorporates an upstream patch from meson: Use pkg-config generator and some cleanups cisco/openh264#3351 to ensure that openh264 respects meson's default_library option, resolving this issue (since this is the mechanism also used by vcpkg to request either the static or shared library).
Which triplets are supported/not supported? Have you updated the CI baseline?
No changes.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes.