-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[liburing] create a new port #17623
[liburing] create a new port #17623
Conversation
Is there anything else that needs to be done for this PR @luncliff? |
Sorry for the pause, Nancy.
I asked my friend for trying this, but not getting any feedback. I checked
symbols with `nm` but not sure the port works correctly.
Let me check some uring samples in GitHub in the upcoming weekend.
…On Thu, May 13, 2021 at 11:27 AM NancyLi1013 ***@***.***> wrote:
Is there anything else that needs to be done for this PR @luncliff
<https://github.com/luncliff>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17623 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLSYE6SNMNNEHZFKTTOX33TNM2JRANCNFSM437F3JPA>
.
|
* with CMake module: FindPkgConfig
I tested build/link of this port with both user@host:build-dbg$ ldd ./test_suite
linux-vdso.so.1 (0x00007fff1a14f000)
liburing.so.2 => /.../vcpkg/installed/x64-linux/debug/lib/pkgconfig/../../lib/liburing.so.2 (0x00007ffbe4c1e000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007ffbe4be5000)
libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007ffbe4a04000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007ffbe48b5000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007ffbe489a000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007ffbe46a8000)
/lib64/ld-linux-x86-64.so.2 (0x00007ffbe4d7e000) Plus, I added user@host:vcpkg$ ./vcpkg install liburing
...
Building package liburing[core]:x64-linux... done
Installing package liburing[core]:x64-linux...
Installing package liburing[core]:x64-linux... done
Elapsed time for package liburing:x64-linux: 8.618 s
Total elapsed time: 8.954 s
The package liburing can be imported via CMake FindPkgConfig module:
include(FindPkgConfig)
pkg_check_modules(URING liburing>=2.0)
target_include_directories(main PRIVATE ${URING_INCLUDE_DIRS})
target_link_libraries(main PRIVATE ${URING_LINK_LIBRARIES})
If you are using CMake v3.13 or higher:
target_link_directories(main PRIVATE ${URING_LIBRARY_DIRS})
|
Co-authored-by: NancyLi1013 <[email protected]>
* update git-tree SHA
* update git-tree SHA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test the usage?
@JackBoosY Yeap. with #17623 (comment) |
LGTM now, thanks for your adding this new port @luncliff. |
@luncliff could you make the versions changes? I apparently can't push to your branch... |
Of course! Thanks for the check and commit. :) |
* update git-tree SHA
@strega-nil-ms please ping me when it's reviewed. :) |
What does your PR fix?
There was no port request for this library. But I think some Linux people are interested in it.
https://github.com/axboe/liburing (It requires kernel version 5.1+.)
Which triplets are supported/not supported? Have you updated the CI baseline?
Targets Linux triplets.
x64-linux
Wish other contributors who use Linux with ARM processor can check this works for those triplets.
Seems like
CC
/CXX
/BUILD_ARCH
customization is required.arm-linux
arm64-linux
Does your PR follow the maintainer guide?
Checked.
I saw Docker images target Linux Kernel 4.x in late 2019.
Considering to check the kernel version in the portfile and warn it.