Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flashlight-cuda] Update port #17645

Merged
merged 10 commits into from
May 21, 2021
Merged

Conversation

jacobkahn
Copy link
Contributor

@jacobkahn jacobkahn commented May 3, 2021

Same as #17643, but for flashlight-cuda.

  • What does your PR fix?

Updates the port to include the fix to flashlight/flashlight#574.

Correctly moves CMake assets in [installed]/share/flashlight-cuda into [installed]/share/flashlight

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No change to supported triplets

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@jacobkahn jacobkahn changed the title [flashlight-cpu] Update port [flashlight-cuda] Update port May 3, 2021
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label May 4, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 11, 2021
@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label May 18, 2021
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 20, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@dan-shaw dan-shaw merged commit 1ee6b34 into microsoft:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants