-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flashlight-cuda] Update port #17645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
reviewed
May 3, 2021
JackBoosY
added
the
category:port-update
The issue is with a library, which is requesting update new revision
label
May 4, 2021
JonLiu1993
approved these changes
May 11, 2021
dan-shaw
reviewed
May 18, 2021
JonLiu1993
removed
the
info:reviewed
Pull Request changes follow basic guidelines
label
May 18, 2021
PhoebeHui
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
May 20, 2021
PhoebeHui
approved these changes
May 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-update
The issue is with a library, which is requesting update new revision
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #17643, but for
flashlight-cuda
.What does your PR fix?
Updates the port to include the fix to flashlight/flashlight#574.
Correctly moves CMake assets in
[installed]/share/flashlight-cuda
into[installed]/share/flashlight
Which triplets are supported/not supported? Have you updated the CI baseline?
No change to supported triplets
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes