[embree3] Fix Embree 3 static compilation patch #17701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NancyLi1013
changed the title
NancyLi1013
added
the
category:port-bug
NancyLi1013
approved these changes
May 7, 2021
|
Hi @chrismile Thanks for your fixing. Have you tested the feature checks added in this PR? |
|
Yes, I have tested the feature checks. Once using a manually patched version of the .cmake files, and once using 'vcpkg install embree3' after adding the commit in this PR. I can confirm that a program linking to Embree with AVX512SKX compiles and runs successfully. I can't directly test whether AVX512KNL works, as I do not have access to a machine supporting it. But if this PR successfully fixes the problems with AVX512SKX, then there should be no reason why AVX512KNL shouldn't work. |
NancyLi1013
approved these changes
May 8, 2021
|
LGTM, thanks for your fixing @chrismile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
ports/embree3/fix-static-usage.patch misses checks for AVX512KNL and AVX512SKX. Without these checks, finding the package in CMake will fail on systems enabling one of these two configurations. The pull request adds the missing checks.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.