Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python3] Update to 3.9.5 #17773

Merged
merged 3 commits into from
May 26, 2021
Merged

[python3] Update to 3.9.5 #17773

merged 3 commits into from
May 26, 2021

Conversation

lakor64
Copy link
Contributor

@lakor64 lakor64 commented May 10, 2021

The following commit updated Python3 to 3.9.5.

NOTE: python2 (non static) must be uninstalled if installed from vcpkg otherwise _freeze_importlib will wrongly try to link python27
(I suppose this is a vcpkg issue)
NOTE2: The patch buils and runs fine on Windows 10 (with deprecated-win7-support enabled), but it has not been tested on Windows 7.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Tested on "x86-windows" and "x86-windows-static"

I think yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@ghost
Copy link

ghost commented May 10, 2021

CLA assistant check
All CLA requirements met.

@Hoikas
Copy link
Contributor

Hoikas commented May 10, 2021

You might also consider updating the python downloaded in vcpkg_find_acquire_program.cmake and in vcpkgTools.xml.

@lakor64
Copy link
Contributor Author

lakor64 commented May 10, 2021

You might also consider updating the python downloaded in vcpkg_find_acquire_program.cmake and in vcpkgTools.xml.

It should be updated now. (the hash should be ok but I didn't knew how to make vcpkg download py3).

@JonLiu1993 JonLiu1993 self-assigned this May 11, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 11, 2021
@Hoikas
Copy link
Contributor

Hoikas commented May 11, 2021

Looks like the CI pipeline needs to be rerun due to spurious failures.

(the hash should be ok but I didn't knew how to make vcpkg download py3).

It's downloaded by other ports as part of their build process. I don't see any errors resulted to that, so it should be all good.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 18, 2021
@strega-nil-ms
Copy link
Contributor

LGTM! Thanks @lakor64 :)

@strega-nil-ms strega-nil-ms merged commit 9d7244f into microsoft:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants