Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ade] fix single config triplets #17935

Merged
merged 2 commits into from
May 18, 2021
Merged

[ade] fix single config triplets #17935

merged 2 commits into from
May 18, 2021

Conversation

cenit
Copy link
Contributor

@cenit cenit commented May 14, 2021

as per title

@PhoebeHui PhoebeHui self-assigned this May 15, 2021
@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label May 15, 2021
PhoebeHui
PhoebeHui approved these changes May 15, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 15, 2021
@dan-shaw dan-shaw merged commit 93dc667 into microsoft:master May 18, 2021
@cenit cenit deleted the dev/cenit/ade branch May 19, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cenit @PhoebeHui @dan-shaw